Easy test but mistake: "," or "." difference in calculated and expected values

Question

when I'm going to do some checks e.g. to equal expected value 17.41 and calculated value (triangle area via 3 sides), calculated value shows the same numbers but with comma "," that why test failed.

enter image description here

org.opentest4j.AssertionFailedError:

Expected :17.41

Actual :17,41

What should I do? Sorry, these are my first steps in QA, seems that I don'y know some easy things))

public class TriangleSquareCalculator {
    public TriangleSquareCalculator() {}

    public double getTriangleSquare(int a, int b, int c) throws Exception {
        if ((a | b | c) <= 0) throw new Exception("Сторона треугольника не может быть меньше, либо равно 0");
        else {
            double s = ((a + b + c) / 2.0) * ((a + b + c) / 2.0 - a) * ((a + b + c) / 2.0 - b) * ((a + b + c) / 2.0 - c);
            return Math.sqrt(s);
       }
    }
}

@Test
    @DisplayName("Проверка выброса исключения при длине стороны треугольника <=0")
    void exeptionIsTriangleSidePositive () throws Exception {
        TriangleSquareCalculator result = new TriangleSquareCalculator();
        Assertions.assertThrows(Exception.class, ()-> result.getTriangleSquare(-3,7,8));
    }

    @Test
    @DisplayName("Проверка проверка правильности рассчета")
    void calculationCheck () throws Exception {
        TriangleSquareCalculator result2 = new TriangleSquareCalculator();
        Assertions.assertEquals(17.41,String.format("%.2f", (result2.getTriangleSquare(7,5,9))));
    }
 }

You can assert the `(result2.getTriangleSquare(7,5,9) -17.41) < 0.01` — c0der, Nov 10 '21 at 14:30
You could specify the Locale in the String.format call to control how it is converted to a String, but it is better to assert it as a double value. — David Conrad, Nov 10 '21 at 14:55

score 3 · Answer 1 · answered Nov 10 '21 at 14:32

In this line

Assertions.assertEquals(17.41,String.format("%.2f"(result2.getTriangleSquare(7,5,9))));

You are comparing a string (on the right) and a double (on the left). You can go for one of the options above to make it right ...

//Option 1 - Compare strings
Assertions.assertEquals("17,41",String.format("%.2f"(result2.getTriangleSquare(7,5,9))));

//Option 2 - Compare numeric values
var precision = 0.01
assertEquals(17.41, result2.getTriangleSquare(7,5,9), precision);

Does this solve your problem ? Tell me in the comments.

score 1 · Accepted Answer · answered Nov 10 '21 at 14:31

1

More likely 17.41 (the double) is not considered equal to "17.41" the string.

JUnit ships with a method specifically for comparing doubles:

assertEquals(17.41, result2.getTriangleSquare(7, 5, 9), .01);

(or perhaps .01 is a bit too lenient a delta, but you get the idea).

EDIT: Somehow I was sure that Assertions wasn't JUnit's class, but it is; text edited to be specific to junit.

answered Nov 10 '21 at 14:31

rzwitserloot

85,357
5
51
72

Thank You, it works!!! – AlexRu Nov 10 '21 at 15:02

Easy test but mistake: "," or "." difference in calculated and expected values

2 Answers2