Warning C26435 Function CXxxx::DoDataExchange should specify exactly one of `virtual`, `override`, or `final` (c.128)

Question

Here is another code analysis warning:

Warning C26435 Function CAssignSelectedColumnDlg::DoDataExchange should specify exactly one of virtual, override, or final (c.128).

Example (boilerplate MFC code):

void CAssignSelectedColumnDlg::DoDataExchange(CDataExchange* pDX)
{
...
...
}

If I understand the documentation correctly, I need to attach either:

... to the function declaration in the header?

score 1 · Accepted Answer · edited Oct 20 '21 at 11:29

1

Yes. The link you posted has another link in it:

You can trust the authors :)

Editors:

Bjarne Stroustrup
Herb Sutter

For others benefit:

void DoDataExchange(CDataExchange* pDX) final;

edited Oct 20 '21 at 11:29

Andrew Truckle

answered Oct 18 '21 at 18:30

Vlad Feinstein

Thank you. In my situation then, I would use the keyword `final` because I would not be deriving a new class from my dialog. That is how I understand this. – Andrew Truckle Oct 18 '21 at 18:38
1

`final` is the correct keyword in this situation. You'd use `override` if the class is intended to be derived from, except when it is the base class of a class hierarchy, in which case the `virtual` keyword is required. The diagnostic is meant to guard against accidentally hiding a `virtual` class member in a derived class with a non-`virtual` class member of the same signature rather than overriding it. This would be legal code that compiles just fine, producing a program that works most of the time. That makes finding this bug particularly challenging. – IInspectable Oct 19 '21 at 07:30

1 Answers1