Java array of ArrayList - strange goings on?

Question

I've been pulling my hair out with this all day. Probably a newb error of some sort, but I can't get my head around it.

It started out more complicated, but I've simplified it to:

public class Main {

    static ArrayList<Selection>[] a = new ArrayList[2];

    public static void main(String[] args) {

        // Initialise the Selection ArrayList

        for (int i=0; i < a.length; i++) {
            a[i] = new ArrayList<Selection>();
        }

        callTest();

    }

    public static void callTest () {

        a[0].add(new Selection(true));
        a[1].add(new Selection(false));

        System.out.println(a[0].get(0).getTF());
        System.out.println(a[1].get(0).getTF());
    }
}

class Selection {

    private static boolean trueFalse;

    public Selection (boolean iTF) {
        trueFalse = iTF;
    }

    public boolean getTF () {
        return trueFalse;
    }
}

Running the program will return:

false
false

instead of the expected (at least to me):

true
false

Can someone please shed some light on this? It appears that whenever the value held in a Selection object is altered, ALL the Selection objects are altered, even though they have a different object reference. Have I done something silly?

Well, I see already static ArrayList[] a = new ArrayList[2]; should be static ArrayList[] a = new ArrayList[2]; — Sam DeHaan, Aug 03 '11 at 18:47
That comes up as invalid as far as my IDE is concerned, but I did try it that way. — shakeshuck, Aug 03 '11 at 19:46
Well, that's strange. I'm a bit out of the Java loop though, so high potential for my fail. — Sam DeHaan, Aug 03 '11 at 19:47
Upon double-checking, even though the IDE complains if it IS there, the compiler itself complains if it ISN'T there. — shakeshuck, Aug 05 '11 at 12:56
Well, that's even more strange, no idea why that would happen. — Sam DeHaan, Aug 05 '11 at 13:26
http://stackoverflow.com/questions/6961783/how-to-create-an-linkedlistobject may have the answer to your IDE/Compiler complaints. — Sam DeHaan, Aug 05 '11 at 20:13

Michael Berry · Accepted Answer · 2012-03-23T18:13:22.190

17

It's because truefalse is static, part of the class and not part of the object. So there's only one truefalse value for all of the Selection objects, and it just gets altered every time a constructor is called. You'll want to remove the static modifier, then all should work as planned!

To avoid problems like this in future, it's best at least while you're starting out to not declare things as static like this - keep to objects where you possibly can, even when you know you're only creating one! This gets you in a nice OO mindset and reduces these types of problems. Of course, there are places where you need to use it and it's the right thing to do, but you'll learn that as you go along.

edited Mar 23 '12 at 18:13

answered Aug 03 '11 at 18:47

Michael Berry

70,193
21
157
216

1

Thanks to all that answered this, makes sense after it's been pointed out to me! – shakeshuck Aug 03 '11 at 20:15
@shakeshuck No problem at all, glad to help! – Michael Berry Aug 03 '11 at 20:23

score 8 · Answer 2 · answered Aug 03 '11 at 18:47

This is because in Selection you declare trueFalse as a static variable. Simply change it to :

class Selection {

    //one per Selection, versus a global variable
    private boolean trueFalse;

    public Selection (boolean iTF) {
        trueFalse = iTF;
    }

}

score 4 · Answer 3 · answered Aug 03 '11 at 18:49

4

Change

private static boolean trueFalse;

to

private boolean trueFalse;

That should fix it. Basically since trueFalse is static, its shared by each instance of the Selection class.

answered Aug 03 '11 at 18:49

arun_suresh

2,875
20
20

score 4 · Answer 4 · answered Aug 03 '11 at 18:50

4

In class Selection you've declared trueFalse as static. That means that it's part of the class, not part of the instances, so it's shared by all the instances.

answered Aug 03 '11 at 18:50

MRAB

20,356
6
40
33

score 4 · Answer 5 · answered Aug 03 '11 at 18:50

From The Java Tutorials:

Class Variables (Static Fields) A class variable is any field declared with the static modifier; this tells the compiler that there is exactly one copy of this variable in existence, regardless of how many times the class has been instantiated.

This is most definitely a "newb" error.

Java array of ArrayList - strange goings on?

5 Answers5