5

like the title mentions I get this error "hint: Waiting for your editor to close the file... " every time I try to commit with this command: git commit. I must mention I am able to commit whilst leaving a message using (-m)

brand new developer here, literally, this is my 4th day at w. development school.
I am using the Pixelbook (Chromebook), Set up with Linux (Beta), it comes with the pixel book. I am using Visual Code Editor (the only one I can use for now because of school)

I told the teachers but they told me not to worry about it but I do. I do not wanna move onto something way harder and then have to deal with a bunch of installing and uninstalling that I do not even understand. Will I ever need to commit whilst using this command: "git commit"? or is it always good to leave a small comment?

I tried doing this https://stackoverflow.com/a/52196507/16928769 which I found here but it does not work, at least following the instructions literally. There might be something I am missing quite simple and obvious but I am only 4 days in.

I have checked and the editor is always closed. I tried closing every open file on the editor etc and nothing changes. Thanks a lot for deciding to waste your time with a newbie like me, much appreciated.

CodeWizard
  • 128,036
  • 21
  • 144
  • 167
voltajc
  • 51
  • 1
  • 2
  • Having a comment that describes the commit's changes is something that many, I think, would consider a best practice. – crashmstr Sep 16 '21 at 14:24
  • That's not an *error*, it's just there so that you can see why Git is just sitting around doing nothing. Git isn't broken: it's sitting around doing nothing while you futz with your editor. Git is waiting for your editor to signal back to Git *I'm done; read the file now*. – torek Sep 16 '21 at 21:10
  • If nothing you can do seems to wake Git, Git and your editor are failing to communicate. That would be a bug in your editor (or in the way you're having Git run it, at least). I don't use VSCode myself but apparently if you have Git run `code --wait`, that's *supposed* to work. – torek Sep 16 '21 at 21:11

2 Answers2

6

You have set up your editor to be something like notepad or any other external program for your editor.

Once you try to commit it open, you have to type your message and close it.

Check to see your editor:

# Show which editor and it path
git config -l --show-origin | grep editor

Using VSCODE

If you are using VSCOde as you mentioned you can commit directly from it.

Open Git "view"

enter image description here

Stage files

enter image description here

Write your commit message

enter image description here

CodeWizard
  • 128,036
  • 21
  • 144
  • 167
  • 1
    good to know! I did not know, I guess we will see this function eventually, but I will try it myself out. Merci! – voltajc Sep 17 '21 at 15:21
2

Git is designed to operate with a wide variety of editors. Some of those editors are terminal-based, like some versions of vi and Emacs, and some are graphical, like Visual Studio Code or Atom.

When Git spawns an editor, it doesn't know whether or not it will be graphical. However, if the editor is graphical, then it may pop up in a window that isn't immediately visible: for example, it may end up behind the current window. This message simply indicates to the user that Git isn't hung; it's waiting for you to edit the commit message, save, and quit the editor. It's merely a helpful hint to help users avoid a potentially confusing situation.

bk2204
  • 64,793
  • 6
  • 84
  • 100