Execute if no exception thrown

Question

I have some code I want to execute if an exception is not thrown.

Currently I'm doing this:

try:
    return type, self.message_handlers[type](self, length - 1)
finally:
    if not any(self.exc_info()):
        self.last_recv_time = time.time()

Can this be improved on? Is this the best way to do it?

Update0

The optional else clause is executed if and when control flows off the end of the try clause.

Currently, control “flows off the end” except in the case of an exception or the execution of a return, continue, or break statement.

Maybe I understand this wrong... but if you `return` something without exception, how can you execute anything afterwards within this method? — eumiro, Aug 02 '11 at 12:43

Thomas K · Answer 1 · 2011-08-02T16:32:23.213

28

try:
   tmp = type, self.message_handlers[type](self, length - 1)
except Exception:
   pass #or handle error, or just "raise" to re-raise
else:
   self.last_recv_time = time.time()
   return tmp

edited Aug 02 '11 at 16:32

answered Aug 02 '11 at 12:22

Thomas K

39,200
7
84
86

1

Nothing will be returned if an exception is thrown within the try-clause – Niklas R Aug 02 '11 at 12:53
@Matt: The `else` clause won't be executed under any circustances, since control can't reach the end of the `try` block. – Sven Marnach Aug 02 '11 at 12:57
I'm sorry the else clause will really never be executed. – Niklas R Aug 02 '11 at 13:29
@Niklas, Matt, Sven: Thanks, you were all right - I'd copied the code in a bit too quickly. I've corrected it now, but I like Sven's solution. – Thomas K Aug 02 '11 at 16:35

score 9 · Accepted Answer · answered Aug 02 '11 at 12:53

9

Your code suggests that you don't want to catch the exception if it occurs, so why not simply

result = type, self.message_handlers[type](self, length - 1)
self.last_recv_time = time.time()
return result

(Am I missing anything?)

answered Aug 02 '11 at 12:53

Sven Marnach

574,206
118
941
841

No you aren't. This does what he asked for. :-) – Lennart Regebro Aug 02 '11 at 14:11
I don't think you're missing anything. Simple is best. – Matt Joiner Aug 04 '11 at 04:35

Execute if no exception thrown

Update0

2 Answers2

Linked