Tkinter Button does nothing when clicked

Question

This is the code for my personal project, for some reason, I can't get the button to do anything when pressed.

Edit: So I managed to fix the text deleting after each input, so now it will continue to output as many passwords as I want. I removed the 0.0 in output.delete so it doesn't default the text to 0 after each generated password.

from tkinter import *
from datetime import datetime
import pyperclip as pc





def close_window():
    window.destroy()
    exit()


# Main GUI program

window = Tk()
window.frame()
window.grid_rowconfigure((0, 1), weight=1)
window.grid_columnconfigure((0, 1), weight=1)
window.title("PW Gen")
window.geometry('+10+10')
window.configure(background="black")
Label(window, bg="black", height=0, width=25, font="Raleway").grid(row=1, column=0, sticky=NSEW)

# Enter the last 4 and generate the password
Label(window, text="Enter the last 4 digits of the Reader Name:", bg="black", fg="white", font="Raleway 12 bold").grid(row=1, column=0, sticky=W)
textentry = Entry(window, width=53, bg="white")
textentry.grid(row=2, column=0, sticky=W)
Button(window, text="Generate Password", width=16, font="Raleway 8 bold", command=click).grid(row=3, column=0, sticky=W)

# Output the password
Label(window, text="\nPassword", bg="black", fg="white", font="Raleway 12 bold").grid(row=4, column=0, sticky=W)
output = Text(window, width=40, height=4, wrap=WORD, background="white")
output.grid(row=5, column=0, columnspan=2, sticky=W)

# Button and Text To Quit GUI
Label(window, text="Click to Quit", bg="black", fg="white", font="Raleway 12 bold").grid(row=6, column=0, sticky=W)
Button(window, text="Quit", width=14, font="Raleway 8 bold", command=close_window).grid(row=7, column=0, sticky=W)

window.mainloop()

Answer 1

Not exactly the best solution but you can definitely give it a try.

import tkinter as tk
from datetime import datetime
import string
import pyperclip as pc
import random
root = tk.Tk()
root.title("PW Gen")
root.geometry('+10+10')
mainframe = tk.Frame(root)
text = tk.Text(root, height=5, width=25, font="Raleway")
def pwgen():
    last4=text.get('1.0','end')[-5:]
    j=[char for char in last4 if char in string.ascii_uppercase or  char in string.ascii_lowercase]
    print(j)
    random.shuffle(j)
    print(j)
    today = datetime.today()
    pw = int(today.strftime("%d")) * int(today.strftime("%m"))
    last4=''.join(j)
    pwgen = "$ynEL" + str(pw) + str()
    pc.copy(pwgen)
    print("\nThe password is $ynEL" + str(pw) + str(last4))
class Application(tk.Frame):
    def __init__(self, master=None):
        super().__init__(master)
        self.quit1 = tk.Button(self, text="QUIT", fg="black", command=self.master.destroy)
        self.quit1.pack(side="top")
        text.pack(side="bottom")
        self.b2 = tk.Button(self)
        self.create_widgets()
        self.pack()
    def create_widgets(self):
        self.b2["text"] = "GenPW"
        self.b2["command"] = pwgen
        self.b2.pack(side="left")
    def b1(self):
        self.b2 = tk.Button(self, text="Generate PW", command=pwgen)
app = Application(root)
root.mainloop()

Answer 2

The code has many problems. mainframe is not shown and never used. Text is shown, but never used. Text is packed inside Application but is not part of Application.

pwgen uses input and no GUI widget. A infinte loop with a GUI application is not good. You should use the attributes of a datetime directly. You should not generate the password at two places in the code. You should not name a local variable like the function. In Application you are using b1 as method, this method is overloaded by the attribute b1, so you cannot use the method anymore. In the method b1 you are generating a new butten instead of calling the function pwgen.

import tkinter as tk
from datetime import datetime
import pyperclip as pc

def pwgen():
    today = datetime.today()
    pw = today.day * today.month
    last4 = input("Last 4 of Reader Name [****] ")
    password = f"$ynEL{pw}{last4}"
    pc.copy(password)
    print("\nThe password is", password)


class Application(tk.Frame):
    def __init__(self, master=None):
        super().__init__(master)
        self.quit = tk.Button(self, text="QUIT", fg="black", command=self.master.destroy)
        self.quit.pack(side="top")
        self.b1 = tk.Button(self, text="GenPW", command=self.click_b1)
        self.b1.pack(side="left")

    def click_b1(self):
        pwgen()


def main():
    root = tk.Tk()
    root.title("PW Gen")
    root.geometry('+10+10')
    text = tk.Text(root, height=5, width=25, font="Raleway")
    text.pack(side="bottom")
    app = Application(master=root)
    app.pack()
    root.mainloop()

if __name__ == "__main__":
    main()

Answer 3

This works. I have used grid manager for more control and removed unused code.

import tkinter as tk
from tkinter import *
from datetime import datetime
import pyperclip as pc

root = tk.Tk()
root.title("PW Gen")
root.geometry('+10+10')
Text = tk.Text(root, height=5, width=25, font="Raleway")

def pwgen():
    while True:
        today = datetime.today()
        pw = int(today.strftime("%d")) * int(today.strftime("%m"))
        last4 = input("Last 4 of Reader Name [****] ")
        pwgen = "$ynEL" + str(pw) + str(last4)

        pc.copy(pwgen)
        print("\nThe password is $ynEL" + str(pw) + str(last4))


class Application(tk.Frame):
    def __init__(self, master=None):
        super().__init__(master)
        self.quit = tk.Button(self, text="QUIT", fg="black", command=self.master.destroy)
        self.quit.grid(row=0,column=0,sticky=tk.EW)
        Text.grid(row=1,column=0,sticky=tk.NSEW)
        self.b1 = tk.Button(self, text="Generate PW", command=pwgen)
        self.b1.grid(row=0,column=1,sticky=tk.EW)
        self.grid(row=0,column=0,sticky=tk.NSEW)

app = Application(master=root)
root.mainloop()

A previous version created multiple Generate PW buttons.