Dispose HttpResponseMessage is it good practice?

Asked Jun 17 '21 at 12:31

Active Jun 17 '21 at 12:31

Viewed 264 times

I am asking this question cause i recently discover that it is not good practice to dispose HttpClient in each request. In other hand it's better to use one instance in whole application. So my question is, if it is better or not to dispose HttpResponseMessage after each request. Here is my code:

private static HttpClient httpClient= new HttpClient();

private async Task<string> SendRequest()
{
    using (HttpResponseMessage result = await httpClient.GetAsync("www.mysite"))
    {
        if (result.IsSuccessStatusCode)
          return await result.Content.ReadAsStringAsync();
    }

    return "";
}

asked Jun 17 '21 at 12:31

Giorgos Papadopoulos

3

You need to dispose `HttpResponseMessage`. You can't re-use them anyway, so the trying to compare it to `HttpClient` isn't a like-for-like comparison, and is meaningless – canton7 Jun 17 '21 at 12:34
4

If it implements IDisposable then dispose it. – Alex K. Jun 17 '21 at 12:35
Thank you Alex K. So my example is correct right? – Giorgos Papadopoulos Jun 17 '21 at 12:36
1

[See this article](https://www.stevejgordon.co.uk/demystifying-httpclient-internals-httpresponsemessage). The author is very knowledgeable. – Crowcoder Jun 17 '21 at 12:36
Thank you Crowcoder, article helped me a lot. – Giorgos Papadopoulos Jun 17 '21 at 12:42

Dispose HttpResponseMessage is it good practice?

0 Answers0