iAd BannerView contentsizeIdentifier Portrait or 320x50?

Question

So in viewdidload i have

adView.requiredContentSizeIdentifiers = [NSSet setWithObject:ADBannerContentSizeIdentifier320x50];
adView.currentContentSizeIdentifier = ADBannerContentSizeIdentifier320x50;

for the banner of an iAd. i I build for iOS 4.2+ the debugger console tells me this:

ADBannerView: ADBannerContentSizeIdentifier320x50 is deprecated, please use ADBannerContentSizeIdentifierPortrait instead

so then i do:

adView.requiredContentSizeIdentifiers = [NSSet setWithObject:ADBannerContentSizeIdentifierPortrait];
adView.currentContentSizeIdentifier = ADBannerContentSizeIdentifierPortrait;

and on 4.1 and lower the app crashes telling me EXC_BAD_ACCESS.

I dont know which one to take, but the one with 320x50 works on newer versions, but i get that notification/error from the console. Any suggestions?

You should remove the answer from the question, add it as an answer and accept it. That will people who come looking for it. — Deepak Danduprolu, Jul 15 '11 at 13:26

JonasG · Accepted Answer · 2011-09-01T14:55:44.413

Ok i got it to work like this:

NSString *os = [[UIDevice currentDevice] systemVersion];
        NSString *ioss = [os stringByReplacingOccurrencesOfString:@"." withString:@""];
        if ([ioss length] == 2) {
            NSLog(@"length = 2");
            float x = ([ioss floatValue]*10);
            NSString *ios = [[NSString alloc] initWithFormat:@"%.f",x];
            if ([ios floatValue] > 419) {
                NSLog(@"Portrait");
                adView.requiredContentSizeIdentifiers = [NSSet setWithObject:ADBannerContentSizeIdentifierPortrait];
                adView.currentContentSizeIdentifier = ADBannerContentSizeIdentifierPortrait;
            } else {
                NSLog(@"320x50");
                adView.requiredContentSizeIdentifiers = [NSSet setWithObject:ADBannerContentSizeIdentifier320x50];
                adView.currentContentSizeIdentifier = ADBannerContentSizeIdentifier320x50;
            }

        }
        else if ([ioss length] == 3) {
            NSString *ios = ioss;
            NSLog(@"length = 3");
            if ([ios floatValue] > 419) {
                NSLog(@"Portrait");
                adView.requiredContentSizeIdentifiers = [NSSet setWithObject:ADBannerContentSizeIdentifierPortrait];
                adView.currentContentSizeIdentifier = ADBannerContentSizeIdentifierPortrait;
            } else {
                NSLog(@"320x50");
                adView.requiredContentSizeIdentifiers = [NSSet setWithObject:ADBannerContentSizeIdentifier320x50];
                adView.currentContentSizeIdentifier = ADBannerContentSizeIdentifier320x50;
            }

        }

Note that this method can be used for all kind of other stuff, what it does is it detects the ios version, and performs an action when it is above a given version and below.

but also this works in my case:

if ( &ADBannerContentSizeIdentifierPortrait != NULL ) {
    adView.requiredContentSizeIdentifiers = [NSSet setWithObject:ADBannerContentSizeIdentifierPortrait];
    adView.currentContentSizeIdentifier = ADBannerContentSizeIdentifierPortrait;
} else {
    adView.requiredContentSizeIdentifiers = [NSSet setWithObject:ADBannerContentSizeIdentifier320x50];
    adView.currentContentSizeIdentifier = ADBannerContentSizeIdentifier320x50;
}

score 2 · Answer 2 · answered Jul 15 '11 at 05:05

2

ADBannerContentSizeIdentifierPortrait doesn't exist on iOS versions before 4.2 so it is raising the error. What you can do is check if the symbol exists and set the properties based on that.

if ( &ADBannerContentSizeIdentifierPortrait != NULL ) {
    self.bannerView.requiredContentSizeIdentifiers = [NSSet setWithObject:ADBannerContentSizeIdentifierPortrait];
    self.bannerView.currentContentSizeIdentifier = ADBannerContentSizeIdentifierPortrait;
} else {
    self.bannerView.requiredContentSizeIdentifiers = [NSSet setWithObject:ADBannerContentSizeIdentifier320x50];
    self.bannerView.currentContentSizeIdentifier = ADBannerContentSizeIdentifier320x50;
}

answered Jul 15 '11 at 05:05

Deepak Danduprolu

44,595
12
101
105

the "self" in front of it is wring, the rest is ok. – JonasG Jul 15 '11 at 13:25
@Maxner Actually I copied it from my sample code where I declared my `ADBannerView` instance as `self.bannerView`. That should explain why I used it. – Deepak Danduprolu Jul 15 '11 at 13:27
@Maxner Additionally [`this link`](http://blog.onstreamtv.de/?p=489) should be helpful with regards to version support. – Deepak Danduprolu Jul 15 '11 at 13:30

iAd BannerView contentsizeIdentifier Portrait or 320x50?

2 Answers2

Linked