c# Deserialize JSON to 3 classes

Question

I have spent 2 days on this problem and still have not solved this...

The Json comes from Firebase Realtime Database.

My absolute goal would be to get the key (Zaptec) as name in the class instead of having to create a "name" property. But that is a question for another day I quess.

My Output:
Name = My Watchlist
Stocks = Models.StocksModel (but value is null)

{
  "name": "My Watchlist",
  "stocks": {
    "Zaptec": {
      "avgPrice": "2,14",
      "name": "Zaptec",
      "shares": 121
    }
  }
}

public class WatchlistModel : INotifyPropertyChanged
{

    private string _name;
    public string Name
    {
        get { return _name; }
        set { _name = value; OnPropertyChanged("Name"); }
    }

    private StocksModel _stocks;
    public StocksModel Stocks
    {
        get { return _stocks; }
        set { _stocks = value; OnPropertyChanged("Stocks"); }
    }
}

public class StocksModel : INotifyPropertyChanged
{
    private StockModel _stocks;
    public StockModel Stocks
    {
        get { return _stocks; }
        set { _stocks = value; OnPropertyChanged("Stocks"); }
    }
}

public class StockModel : INotifyPropertyChanged
{
    #region -- Properties --
    private string _name;
    public string Name
    {
        get { return _name; }
        set { _name = value; OnPropertyChanged("Name"); }
    }

    private string _avgPrice;
    public string AvgPrice
    {
        get { return _avgPrice; }
        set { _avgPrice = value; OnPropertyChanged("AvgPrice"); }
    }

    private string _shares;
    public string Shares
    {
        get { return _shares; }
        set { _shares = value; OnPropertyChanged("Shares"); }
    }
}

Hey please check my answer. I explained how to deserialize the Stocks property — Jonathan Alfaro, Apr 04 '21 at 16:18

Jonathan Alfaro · Accepted Answer · 2021-04-04T16:16:45.993

Your model should look like this:

public class WatchlistModel : INotifyPropertyChanged
{

    private string _name;
    public string Name
    {
        get { return _name; }
        set { _name = value; OnPropertyChanged("Name"); }
    }

    private Dictionary<string, StockModel> _stocks;
    public Dictionary<string, StockModel> Stocks
    {
        get { return _stocks; }
        set { _stocks = value; OnPropertyChanged("Stocks"); }
    }
}

You do not need the StocksModel... You need a dictionary of StockModel. As for how this would work with INotifyPropertyChanged that is a different story. But as for the json the correct model is what is shown on this answer.

You should be able to do something like JsonConvert.Deserialize(jsonString)

Also just as a recommendation before you fire the OnPropertyChanged event, you should check if the value actually changed. Something like:

if(_name != value)
{
  _name = value;
  OnPropertyChanged("Name");
}

And lastly your implementation of OnPropertyChanged should use a "Caller" attribute that way you don't have to hardcode the property name like "Name".

Thanks! By "Caller" attribute, do you mean something like this?: PropertyChanged(this, new PropertyChangedEventArgs(propertyName)); — Gnusson, Apr 04 '21 at 16:37
I have this on my viewmodel base: OnPropertyChanged([CallerMemberName] string propertyName = null) But this does not work... — Gnusson, Apr 04 '21 at 16:44
@Gnusson so in theory you dont need to pass the property name... It should pick it automatically: OnPropertyChanged() — Jonathan Alfaro, Apr 04 '21 at 17:15

c# Deserialize JSON to 3 classes

1 Answers1