check empty values PHP more short of code

Question

Is there a way to do this, but in a shorter way? or "more professional" way? Thanks and regards. Check variables is empty (check if one is empty).

if((
empty($varone) || 
empty($vartwo) || 
empty($vthree) || 
empty($vardf) || 
empty($vfgsdgsdal) || 
empty($pasadfsd) || 
empty($efda) 
)) {
    $response = "There is an empty data";
    }else{$response = "NO EMPTY DATA!";}

Pass variables in array and run loop. if value is empty return message or you can try [this.](https://stackoverflow.com/a/7798842/13359052) — Robin Singh, Mar 23 '21 at 07:43
I have added more better way to achieve your goal. Please have a look my answer. — Rashed Rahat, Mar 23 '21 at 07:52

score 2 · Answer 1 · answered Mar 23 '21 at 07:47

Firt solution, add values in array and tests if there is empty value

function checkEmptyValueArray($values) {
    return !empty(array_filter($values, function ($value) {
        return empty($value);
    }));
}

$values = [$varone, $vartwo, $vthree, $vardf, $vfgsdgsdal, $pasadfsd, $efda];

if ( checkEmptyValueArray($values) ) {
    $response = "There is an empty data";
} else{
    $response = "NO EMPTY DATA!";
}

An other solution is to use variable-length arguments list

Follow this link for an explanation : https://www.php.net/manual/en/functions.arguments.php

function checkEmptyValueArray(...$args) {
    foreach ( $args as $arg ) {
        if ( empty($arg) ) {
            return true;
        }
    }
    return false;
}

if ( checkEmptyValueArray($varone, $vartwo, $vthree, $vardf, $vfgsdgsdal, $pasadfsd, $efda) ) {
    $response = "There is an empty data";
} else{
    $response = "NO EMPTY DATA!";
}

I don't know which of your solutions i prefer, both are great ^^. — Astro-Otter, Mar 23 '21 at 07:52

score 1 · Answer 2 · answered Mar 23 '21 at 07:52

1

Try this more professional, simple & elegant way:

if (in_array("", array($varone, ..., $varN)) {
   $response = "There is an empty data";
} else {
   $response = "There is not any empty data";
}

Happy coding :)

answered Mar 23 '21 at 07:52

Rashed Rahat

2,357
2
18
38

It also works for the values you mentioned. Tested :) – Rashed Rahat Mar 23 '21 at 07:56
Well with 0 it does not work (on php8), my bad for null ;) https://3v4l.org/3vsOV – Yoleth Mar 23 '21 at 07:59
2

What makes this "more professional"? I don't even know what that means in this context, tbh. Also, `empty()` checks for more things than just an empty string. – M. Eriksson Mar 23 '21 at 08:05

check empty values PHP ​more short of code

2 Answers2

check empty values PHP more short of code