What is the bast solution in this case

Question

I would like to get your recommend.

    // Solution one 
    $total_user=User::count();
    $active_user=User::where('active', 'active')->count();
    
    
    // Solution two 
    $user = User::all();
    $total_user=$user->count();
    $active_user=$user->where('active','active')->count();

Note : the number of users will become more then at least 1 million.
Thank all

score 2 · Answer 1 · answered Jan 19 '21 at 11:28

2

i think solution 1 is better

because in solution 2 you are getting all the data from database and then counting them and it costs much more time than just counting them in solution 1

so my choice is solution 1

answered Jan 19 '21 at 11:28

milad hedayatpoor

626
4
15

score 1 · Answer 2 · answered Jan 19 '21 at 11:29

1- First we pull all records with a single query

$users = User::select('id', 'active')->get();

Notice : With SELECET, we only bring the selected fields belonging to the user, if there is no need for other important user information for speed.

2- We filter

$active_users    = $users->filter(function ($row) {
   return $row->aktive == 'active';
});

3- Then we write(in view)

Total :{{ count($users) }}
Active :{{ count($active_users) }}

What is the bast solution in this case

2 Answers2