I try to build ROT 13 cipher in JavaScript, I did it but output not shown in console please check what's wrong in it

Question

A common modern use is a ROT13 cipher, where the values of the letters are shifted by 13 places. Thus 'A' ↔ 'N', 'B' ↔ 'O', and so on.

function rot13(str) {
    let newStr="";
  let upperAlph=["A","B","C","D","E","F","G","H","I","J","K","L","M","N","O","P","Q","R","S","T","W","X","Y","Z"]
  let rotAlph=["N","O","P","Q","R","S","T","U","V","W","X","Y","Z","A","B","C","D","E","F","G","H","I","J","K","L","M"];
  for(let i=0; i<str.length; i++){
 
    let letter=str[i];
    let letTest=/[A-Z]/g;
    if(letTest.test(letter)){
      let indexOfLetter=upperAlph.indexOf(letter);
      let newLetter=rotAlph[indexOfLetter];
      newStr+newLetter;
    }
    else{
      newStr+letter;
    }
  }
  return newStr;
}

console.log(rot13("SERR PBQR PNZC"));

‘NewStr+whatever’ is incorrect – Alan P. Jan 16 '21 at 03:24 — Alan P., Jan 16 '21 at 03:24
@AlanP. I used "concat()" too but still not working – Avinash Dhumal Jan 16 '21 at 03:29 — Avinash Dhumal, Jan 16 '21 at 03:29
FYI, `upperAlph` is missing `U` and `V`. – chuckx Jan 16 '21 at 03:38 — chuckx, Jan 16 '21 at 03:38

farhodius · Accepted Answer · 2021-01-16T03:36:03.407

Fixed your code, look at lines 12 and 15 I believe:

function rot13(str) {
    let newStr="";
  let upperAlph=["A","B","C","D","E","F","G","H","I","J","K","L","M","N","O","P","Q","R","S","T","W","X","Y","Z"]
  let rotAlph=["N","O","P","Q","R","S","T","U","V","W","X","Y","Z","A","B","C","D","E","F","G","H","I","J","K","L","M"];
  for(let i=0; i<str.length; i++){
 
    let letter=str[i];
    let letTest=/[A-Z]/g;
    if(letTest.test(letter)){
      let indexOfLetter=upperAlph.indexOf(letter);
      let newLetter=rotAlph[indexOfLetter];
      newStr += newLetter;
    }
    else{
      newStr += letter;
    }
  }
  return newStr;
}

console.log(rot13("SERR PBQR PNZC"));

I would also use map type object instead of 2 arrays:

alphMap = {A: 'N', B: 'O', C: 'P', ..., Z: 'M'};

You can find your substitute letter like so:

let newLetter = alphMap[letter];

No need to match indexes.

score 0 · Answer 2 · answered Mar 01 '22 at 15:40

You missed the U and V of upperAlph

    function rot13(str) {
    let newStr="";
    let upperAlph=["A","B","C","D","E","F","G","H","I","J","K","L","M","N","O","P","Q","R","S","T","U","V","W","X","Y","Z"]
  let rotAlph=["N","O","P","Q","R","S","T","U","V","W","X","Y","Z","A","B","C","D","E","F","G","H","I","J","K","L","M"];
  for(let i=0; i<str.length; i++){
 
    let letter=str[i];
    let letTest=/[A-Z]/g;
    if(letTest.test(letter)){
      let indexOfLetter=upperAlph.indexOf(letter);
      let newLetter=rotAlph[indexOfLetter];
      newStr += newLetter;
    }
    else{
      newStr += letter;
    }
  }
  return newStr;
}

I try to build ROT 13 cipher in JavaScript, I did it but output not shown in console please check what's wrong in it

2 Answers2