i cant get this TypeError fixed

Question

error message:

`Traceback (most recent call last):
  File "main.py"  line 23, in <module>
    if gold>="4":
TypeError: '>=" not supported between instances of 'int' and 'str'`

my code:

Code:

import random
hp=34
maxhp=34
strenth=5
weapon='fist'
gold=0
monsters=["goblin","Orc","hobgoblin","dragon","Troll","tarasque"]
while hp>=1:
  print('\ngold:',gold)
  print('\nhp:',hp)
  print('\nmaxhp:',maxhp)
  print('\nstrenth:',strenth)
  print('\nweapon:',weapon)
  print("\n\n[1]BATTLE!!!\n[2]shop")
  answer=input()
  if answer=='1':
    random.choice(monsters)
  elif answer=="2":
    print('what would nyou like to purchase?\n\n[1]small heal                       5 gold\n[2]moderate heal                   20 gold\n[3]large heal                     100 gold\n[4]small strenth boost             50 gold\n[5]moderate strenth boost         200 gold\n[6]large strenth boost           1000 gold\n[7]small maxhp boost              500 gold\n[8]moderate maxhp boost          2000 gold\n[9]large maxhp boost            10000 gold\n[10]sacrafice 20 hp for 5 gold     20   hp\n\n\nwhatis ur choice')
    print('gold:',gold)
    shop=input()
    if shop=='1':
      if gold>="4":
        gold-=5

    elif shop=='2':
      if gold>="19":
        gold-=20

    elif shop=='3':
      if gold >= "99":
        gold-=100

    elif shop=='4':
      if gold >= "49":
        gold-=50

    elif shop == '5':
      if gold>="199":
        gold-=200

    elif shop == '6':
      if gold>="999":
        gold-=1000

    elif shop == '7':
      if gold>="499":
        gold-=500

    elif shop == '8':
      if gold>="1999":
        gold-=2000

    elif shop == '9':
      if gold>="9999":
        gold-=10000

    elif shop == '10':
      hp-=20
      gold+=5
      print("you sacraficed your health to gain money. not exacly a wise move.")
      input()
    else:
      print('what? thats not a legal input\nnow get out!')
      input()
while hp>=maxhp:
  hp-=1
while hp<=1:
  print("G A M E\n   O V E R")

im relatively new to python and i have researched sites with solutions that did not work. i have been using repl.it for this.

`gold` is an integer value, and `"4"` is a string value. You can't compare those. Perhaps you meant `if gold >= 4` instead, without the quotes? — John Gordon, Jan 11 '21 at 23:25
Yeah, you can not compare integer with a string. you need either to compare a string with a string or int with int. you can also cast to string or to int like: `int("4")` or `string(4)`. in your case it better to compare an integer with an integer value. — Utmost Creator, Jan 11 '21 at 23:34

score 1 · Answer 1 · answered Jan 11 '21 at 23:38

1

The error causes due to the fact that you are comparing two data types as of integer and string.

gold=0 # integer value
if gold>="4": # string, just write it as 4
        gold-=5

I guess this helps you.

answered Jan 11 '21 at 23:38

nectarBee

401
3
9

score 1 · Answer 2 · answered Jan 11 '21 at 23:54

All inputs are strings in Python, if you only need to use them as integers, just convert immediately. I went ahead and improved your code. PS. Why do rookies never use spaces

import random
hp = 34
maxhp = 34
strenth = 5
weapon = "fist"
gold = 1000
monsters = ["goblin", "Orc", "hobgoblin", "dragon", "Troll", "tarasque"]

 shop_choices = {
        1: 5, 2: 20, 3: 50,
        4: 100, 5: 200, 6: 500,
        7: 1000, 8: 2000, 9: 10000
    }

def spend_gold(gold, amount):
        if gold >= amount:
            gold -= amount
        return gold

while hp >= 1:
    print('\ngold:', gold)
    print('\nhp:', hp)
    print('\nmaxhp:', maxhp)
    print('\nstrenth:', strenth)
    print('\nweapon:', weapon)
    print("\n\n[1]BATTLE!!!\n[2]shop")
    answer = int(input()

    if answer == 1:
        random.choice(monsters)
    elif answer == 2:
        print("what would nyou like to purchase?\n\n[1]small heal                       5 gold\n[2]moderate heal                   20 gold\n[3]large heal                     100 gold\n[4]small strenth boost             50 gold\n[5]moderate strenth boost         200 gold\n[6]large strenth boost           1000 gold\n[7]small maxhp boost              500 gold\n[8]moderate maxhp boost          2000 gold\n[9]large maxhp boost            10000 gold\n[10]sacrafice 20 hp for 5 gold     20   hp\n\n\nwhatis ur choice")
        print("gold:", gold)
        shop = int(input())
        if shop in shop_choices:
            gold = spend_gold(gold, shop_choices[shop])
        elif shop == 10:
            hp -= 20
            gold += 5
            print("you sacraficed your health to gain money. not exacly a wise move.")
            input()
        else:
            print('what? thats not a legal input\nnow get out!')
            input()
while hp >= maxhp:
    hp -= 1
while hp <= 1:
    print("G A M E\n   O V E R")

i cant get this TypeError fixed

2 Answers2