2to3 not resolving .sort() to sorted()

Question

I'm attempting to convert a library from Py 2.7.x to Py 3.7.x using 2to3 on Win10. Following reference from here.

I've seen that to convert some parts of Python you need to explicitly add Fixers, specifically:

idioms

This optional fixer performs several transformations that make Python code more idiomatic. Type comparisons like type(x) is SomeClass and type(x) == SomeClass are converted to isinstance(x, SomeClass). while 1 becomes while True. This fixer also tries to make use of sorted() in appropriate places. For example, this block

L = list(some_iterable) L.sort() is changed to

L = sorted(some_iterable)

So I add it to my commandline:

2to3 --output-dir=C:\my\py3\module -f all -f buffer -f idioms -f set_literal -f ws_comma -W -n C:\my\py2\module

2to3 will generate the correct files in the C:\my\py3\module folder but list.sort() has not been resolved to sorted(list)

What am I missing here?

`list.sort()` is still a thing - it sorts the list in place. `sorted(..)` creates a new sorted list and returns it .. — Patrick Artner, Jan 09 '21 at 20:04

score 1 · Answer 1 · answered Jan 09 '21 at 20:15

1

It looks like the fixer literally only works for an

x = list(z)
x.sort()

pattern, not anything fancier. After all 2to3 doesn't do type analysis.

answered Jan 09 '21 at 20:15

AKX

152,115
15
115
172

Geordie · Accepted Answer · 2021-01-09T20:30:42.443

0

Product of trying to convert a lib off github at 3am. The real issue is the changes between the return value of dictionary .keys() between Py2 and Py3.

Snippet from lib I was running through 2to3:

keys = timeSamples.keys()
keys.sort()

Which I changed to:

keys = sorted(timeSamples.keys())

If I'd actually read the error message would have seen was trying to call .sort() on dict_keys type not list in Py3.

edited Jan 09 '21 at 20:30

answered Jan 09 '21 at 20:22

Geordie

1,920
2
24
34

2to3 not resolving .sort() to sorted()

2 Answers2