4

Problem Description

I added the following enum structure to my protobuf:

  enum FooType {
    INVALID = 0;
    OW      = 1;
    RT      = 2;
    OJ      = 3;
    MC      = 4;
  }
[...]
optional FooType foo_type = 22 [default = INVALID];

What happens if we insert a value greater than 4? The idea is that, every value greater than 4 should be INVALID. I am doing that check in the code on my side.

if(Foo > 4) {
  Foo = 0;
}
//add to protobuf

This solution looks dirty. Is there a way to set that condition somewhere in the protobuf.


Protobuf Generated Code

In the generated code we have the following condition.

case 22: {
        if (tag == 176) {
         parse_itinerary_type:
          int value;
          DO_((::google::protobuf::internal::WireFormatLite::ReadPrimitive<
                   int, ::google::protobuf::internal::WireFormatLite::TYPE_ENUM>(
                 input, &value)));
          if (::sss::model::protoBom::common::Context_FooType_IsValid(value)) {
            set_itinerary_type(static_cast< ::sss::model::protoBom::common::Context_FooType >(value));
          } else {
            mutable_unknown_fields()->AddVarint(22, value);
          }
        } else {
          goto handle_unusual;
        }
        if (input->ExpectAtEnd()) goto success;
        break;
      }

I didn't understand mutable_unknown_fields()->AddVarint(22, value); The value that being assigned is not the default value. It's just the value that we sent as argument.

where:

bool Context_Footype_IsValid(int value) {
  switch(value) {
    case 0:
    case 1:
    case 2:
    case 3:
    case 4:
      return true;
    default:
      return false;
  }
}
Hani Gotc
  • 840
  • 11
  • 24

0 Answers0