How to display an imageview from a url with holder

Question

to display the images on the Imageview from an url I use this code, but without success :

class Article(var id:Int,var nom:String,var lienimg:String, var ifram:String){
}

class ArticleAdapter (var articles:ArrayList<Article>) : RecyclerView.Adapter<ArticleAdapter.MyViewHolder>(){
    override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): MyViewHolder {
        var vue=LayoutInflater.from(parent.context).inflate(R.layout.listeviss, parent, false)
        return MyViewHolder(vue)
    }
    override fun getItemCount(): Int {
        return articles.size
    }
    override fun onBindViewHolder(holder: MyViewHolder, position: Int) {
        var article = articles.get(position)
        holder.nomvisite.setText(article.nom)
        holder.lieimgvisite.setText(article.lienimg)
        holder.ifram.setText(article.ifram)


        var urldelimg:String = "linkmysite.com/image.jpg"
        Glide.with(this).load(urldelimg).into(holder.imagedubloc)

    }

    class MyViewHolder(var vue:View):RecyclerView.ViewHolder(vue){
        var nomvisite=vue.findViewById<TextView>(R.id.nom_visitevirtuelle)
        var lieimgvisite=vue.findViewById<TextView>(R.id.lienimg)
        var ifram=vue.findViewById<TextView>(R.id.ifram)
        var imagedubloc=vue.findViewById<ImageView>(R.id.imagedubloc)

    }

i have this error :

None of the following functions can be called with the arguments supplied: 
public open fun with(p0: Activity): RequestManager defined in com.bumptech.glide.Glide
public open fun with(p0: android.app.Fragment): RequestManager defined in com.bumptech.glide.Glide
public open fun with(p0: Context): RequestManager defined in com.bumptech.glide.Glide
public open fun with(p0: View): RequestManager defined in com.bumptech.glide.Glide
public open fun with(p0: androidx.fragment.app.Fragment): RequestManager defined in com.bumptech.glide.Glide
public open fun with(p0: FragmentActivity): RequestManager defined in com.bumptech.glide.Glide

How can I fix this and display the image without error ? Thank You

Can you share the full code of the Adapter – emkarachchi Jan 02 '21 at 14:20 — emkarachchi, Jan 02 '21 at 14:20
@emkarachchi i just edit the code and add the adapter – admindunet Jan 02 '21 at 14:24 — admindunet, Jan 02 '21 at 14:24

martinseal1987 · Accepted Answer · 2021-01-03T08:47:47.010

1

Most likely where you've passed this to Glide.with(this) probably references the class and glide doesn't have a constructor that takes that, give it a view like Glide.with(holder.yourView) this is giving it a view which should fix it

edited Jan 03 '21 at 08:47

answered Jan 02 '21 at 14:27

martinseal1987

1,862
8
44
77

actually i take this back but you do need a view or a context so maybe holder.ifram or holder.ifram.context – martinseal1987 Jan 02 '21 at 14:39
if i change Glide.with(this) with Glide.with(holder) i get a same error – admindunet Jan 02 '21 at 15:04
Yh sorry I mentioned changing it to holder.yourView like holder.ifram.context for example – martinseal1987 Jan 02 '21 at 17:58
i test this : Glide.with(holder.imagedubloc.context).load(urldelimg).into(holder.imagedubloc) app load but not image showing – admindunet Jan 02 '21 at 18:07
Then there's something else wrong, what's the logs saying? – martinseal1987 Jan 02 '21 at 19:30
Can you share your image link? – martinseal1987 Jan 02 '21 at 19:33
logcat : W/Glide: Failed to find GeneratedAppGlideModule. You should include an annotationProcessor compile dependency on com.github.bumptech.glide:compiler in your application and a @ GlideModule annotated AppGlideModule implementation or LibraryGlideModules will be silently ignored – admindunet Jan 02 '21 at 19:46
ahh its work :) can i do it in imagebutton ? – admindunet Jan 02 '21 at 20:02
Yh course, looks like you.mighy be missing an annotation processor or your app glide module isn't set up correctly glad it's working though can you accept my answer as correct – martinseal1987 Jan 02 '21 at 21:48

score 0 · Answer 2 · edited Jan 02 '21 at 14:36

0

Here is how I've achieved the same behavior using java.

When creating a new Adapter object, you need to pass the Activity Context.

myRecyclerViewAdapter = new MyAdapter(dataList,getActivity());

create a Context variable in your adapter class

private final Context context;

Then in the constructor of the Adapter class

public MyAdapter(List<MyData> dataSet, Context context)
{
    this.dataSet = dataSet;
    this.context = context; //this line should be added
}

Finally, you can load the image as follows.

Glide.with(context).load(imageUrl).into(holder.imageView);

edited Jan 02 '21 at 14:36

Dharman

30,962
25
85
135

answered Jan 02 '21 at 14:30

emkarachchi

750
1
7
18

1

you should avoid this where possible, its not completely bad but the less you pass around context the better, if you need a context get it from the view like for instance in onCreateViewHolder(parent: ViewGroup, viewType: Int) you can get a context using parent.context – martinseal1987 Jan 02 '21 at 14:37
and using getActivity() should also be discouraged where possible as it can be null if called from a fragment again you can substitute this by using a view – martinseal1987 Jan 02 '21 at 14:42
@martinseal1987 I was doing this inside a fragment class. but I couldn't find it becoming `null`. But I wasn't aware of the `parent.context ` thing. Thanks. – emkarachchi Jan 02 '21 at 14:48
Yh I'm surprised the IDE isn't highlighting it to tell you this could be null – martinseal1987 Jan 02 '21 at 17:57

score 0 · Answer 3 · answered Jan 02 '21 at 14:35

0

Instead of Glide.with(this), provide associated UI context in adapter's constructor and use like: Glide.with(context)

answered Jan 02 '21 at 14:35

harpal Singh

1
3

if i change Glide.with(this) to Glide.with(context) i get this error : Classifier 'Context' does not have a companion object, and thus must be initialized here – admindunet Jan 02 '21 at 15:01

How to display an imageview from a url with holder

3 Answers3