How to control AlertDialog

Question

I have created an app which includes popups of different dialogs.

Here is my code:

if (lDiffFromToday >= 0 && lDiffFromToday <= DeclareVariable.CYCLE_MAX_LENGTH)
{
    AlertDialog.Builder alrtStartMonitoring = new AlertDialog.Builder(this);
    alrtStartMonitoring.setTitle("              Start Monitoring");
    alrtStartMonitoring.setMessage("Set start date of cycle as"+" "+sdFormatter.format(dtSelDate));
    alrtStartMonitoring.setPositiveButton("Yes", this);
    AlertDialog alert = alrtStartMonitoring.create();
    alert.show();
}   
else if (dtSelDate.getTime()> dtStartDate.getTime() && dtSelDate.getTime() <= currentDate.getTime() && !bCycleStopped)
{
    long lDiffFromStart =dtSelDate.getTime()-dtStartDate.getTime();
    lDiffFromStart=lDiffFromStart/(1000 * 60 * 60 * 24);
    if (lDiffFromStart >= DeclareVariable.CYCLE_MIN_LENGTH)
    {
        bActionOk = true;
        AlertDialog.Builder alrtStartMonitoring = new AlertDialog.Builder(this);
        alrtStartMonitoring.setTitle("              Confirm New Cycle");
        alrtStartMonitoring.setMessage("Set start date of cycle as" + " " + sdFormatter.format(dtSelDate));
        alrtStartMonitoring.setPositiveButton("Yes", this);
        AlertDialog alert = alrtStartMonitoring.create();
        alert.show();
    }
}

// ...

public void onClick(DialogInterface dialog, int id) 
{
    CycleManager.getSingletonObject().setHistoryDate(dtSelDate);
    int iStopStartCount = CycleManager.getSingletonObject().getStopStartCount();                
    if(iStopStartCount>0)
        CycleManager.getSingletonObject().setStopStartDate(dtSelDate, iStopStartCount);
    displayDay();
}

Now my question is that for each dialog I need different onClick functions but in my case when I write another onClick function then there will be conflict. I know by writing the onClick function inside each dialog may solve the problem but in that case, I have to declare my variables as final so how can I do it by writing onClick function outside for every dialog I used.

Please, format the code correctly. – mohamede1945 Jul 01 '11 at 12:05 — mohamede1945, Jul 01 '11 at 12:05
sorry for that can you please tell me the answer – AndroidDev Jul 01 '11 at 12:08 — AndroidDev, Jul 01 '11 at 12:08

score 1 · Accepted Answer · answered Jul 01 '11 at 12:09

1

Another solution will be to make the AlertDialog instances members of your class. Then in the OnClick method:

public void onClick(DialogInterface dialog, int id) 
{
  if (dialog == m_Dialog1)
  {
    // server dialog 1
  }

}

answered Jul 01 '11 at 12:09

kgiannakakis

103,016
27
158
194

is this correct? If you're implementing the onClick from [DialogInterface.OnClick()](http://developer.android.com/reference/android/content/DialogInterface.OnClickListener.html) then the id is the button id that was pressed. – Mark Fisher Jul 01 '11 at 12:21
Yes, but I'm not checking the Id, but the dialog itself. – kgiannakakis Jul 01 '11 at 12:29

score 0 · Answer 2 · answered Jul 01 '11 at 12:11

0

I can see that you've made the your class to implement the DialogInterface.OnClickListener

instead of

alrtStartMonitoring.setPositiveButton("Yes", this);

You can make it this way

alrtStartMonitoring.setPositiveButton("Yes", new DialogInterface.OnClickListener() {

public void onClick (DialogInterface dialog, int which) {

}
});

and for each one of the setPositiveButton you can define the different onClick listener

Hope this helps

answered Jul 01 '11 at 12:11

mohamede1945

7,092
6
47
61

yeh that i know but on doing so i have to made my variable final which is not needed..thats why i skip this step – AndroidDev Jul 01 '11 at 12:13
If you declare them as instance variable, you won't need to have them final. – mohamede1945 Jul 01 '11 at 12:27
yeh you are right but on popup of second dialog when i click on ok it gives an error in the device and the app terminate..\ – AndroidDev Jul 01 '11 at 12:44

score 0 · Answer 3 · answered Jul 01 '11 at 12:28

Why not create your own DialogInterface.OnClickListener classes and instantiate them with the appropriate variables from your main class that you don't want to mark as final, but do want them to have access to (inject them effectively). Then you can do

FooDialogOnClickListener l1 = new FooDialogOnClickListener(dtSelData, ...);
BarDialogOnClickListener l2 = new BarDialogOnClickListener(iStopStartCount, ...);

if (...) {
    // ...
    alrtStartMonitoring.setPositiveButton("Yes", l1);
} else {
    // ...
    alrtStartMonitoring.setPositiveButton("Yes", l2);
}

How to control AlertDialog

3 Answers3