How to pass runtime parameters to a ViewModel's constructor when using Hilt for dependency injection?

Question

I'm wondering how to pass runtime parameters to a ViewModel's constructor while using Hilt for DI? Prior to using Hilt, I have a ViewModel that looks like this:

class ItemViewModel(private val itemId: Long) : ViewModel() {
    private val repo = ItemRepository(itemId) 
}

class ItemViewModelFactory(private val itemId: Long) : ViewModelProvider.Factory {
@Suppress("unchecked_cast")
override fun <T : ViewModel?> create(modelClass: Class<T>): T {
    if (modelClass.isAssignableFrom(ItemViewModel::class.java)) {
        return ItemViewModel(itemId) as T
    }
    throw IllegalArgumentException("Unknown ViewModel class")
}

I create the above ViewModel in my fragment like this:

override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {

    val args: ItemScreenFragmentArgs by navArgs()
    val itemId = args.itemId

    //Create the view model factory
    val viewModelFactory = ItemViewModelFactory(application, itemId)

    // Get a reference to the ViewModel associated with this fragment.
    val itemViewModel = ViewModelProvider(this, viewModelFactory).get(ItemViewModel::class.java)
}

If my ItemViewModel constructor didn't have the itemId parameter, my ViewModel and Fragment using Hilt would look like this:

class ItemViewModel
@ViewModelInject
constructor(private val repo: ItemRepository) : ViewModel() { }

@AndroidEntryPoint
class ItemFragment : Fragment() {
    private val itemViewModel: ItemViewModel by viewModels ()
}

I'm trying to figure out how to pass the itemId that I get from the ItemFragment's NavArgs to the ItemViewModel's constructor? Is there a way to do this with Hilt?

score 25 · Accepted Answer · answered Dec 19 '20 at 23:19

For anyone else looking to pass runtime parameters to a ViewModel while using Dagger Hilt, this is how I did it:

I followed the code from this example which uses the AssistedInject library.

My code now looks as follows:

class ItemViewModel
@AssistedInject
constructor(private val repo: ItemRepository, @Assisted private val itemId: Long) : ViewModel() {
    init {
        repo.itemId = itemId
    }

    @AssistedInject.Factory
    interface AssistedFactory {
        fun create(itemId: Long): ItemViewModel
    }

    companion object {
        fun provideFactory(
            assistedFactory: AssistedFactory,
            itemId: Long
        ): ViewModelProvider.Factory = object : ViewModelProvider.Factory {
            override fun <T : ViewModel?> create(modelClass: Class<T>): T {
                return assistedFactory.create(itemId) as T
            }
        }
    }
}

@InstallIn(FragmentComponent::class)
@AssistedModule
@Module
interface AssistedInjectModule {}

@AndroidEntryPoint
class ItemFragment : Fragment() {
    private val args: ItemScreenFragmentArgs by navArgs()      
    @Inject lateinit var itemViewModelAssistedFactory: ItemViewModel.AssistedFactory        
    private val itemViewModel: ItemViewModel by viewModels {
            ItemViewModel.provideFactory(itemViewModelAssistedFactory, args.itemId)
    }    
}

thx but i got error like below with hilt 2.35: ViewModel constructor should be annotated with [at]Inject instead of [at]AssistedInject. [Hilt] Processing did not complete. See error above for details. — gturedi, Jul 18 '21 at 22:15
@gturedi you have to remove HiltViewModel in your viewmodel to use AssistedInject but in the latest update you could possible pass argument by using SavedStateHandle. see it here, https://github.com/google/dagger/issues/2287#issuecomment-771671159 — Jack, Aug 04 '21 at 09:17
I followed this approach. I keep getting `AssistedInjectModule is missing an @InstallIn annotation` even though I have kept `@InstallIn(SingletonComponent::class)` — Neeraja Gandla, Oct 16 '21 at 16:20

Salam El-Banna · Answer 2 · 2022-11-01T11:04:17.863

11

There is a better solution without AssistedInject, just use the SavedStateHandle.

if the args in your fragment contains userId:

val args: UserFragmentArgs by navArgs()
...
args.userId

Then simply in your savedStateHandle it will be available without additional work.

class UserViewModel @Inject constructor (
    private val state: SavedStateHandle
) : ViewModel() {

    //Get the value of the userId here
    val userId = state.get<String>("userId")


   //Also you can do this using safe args
   val args = UserFragmentArgs.fromSavedStateHandle(state)
   val userId = args.userId
}

Full Implementation details: https://mattrobertson.dev/passing-safe-args-to-your-viewmodel-with-hilt-366762ff3f57

edited Nov 01 '22 at 11:04

answered Apr 19 '22 at 08:37

Salam El-Banna

3,784
1
22
34

1

Adding to this: You can now even do this in a type-safe manner. `val args = UserFragmentArgs.fromSavedStateHandle(state); val userId = args.user` – Christian Brüggemann Jul 23 '22 at 18:24
Unresolved reference UserViewModelFactory. Can you add the gradle implementations? – Emirhan Soylu Dec 15 '22 at 13:02

score 4 · Answer 3 · answered Jan 13 '22 at 20:26

Assisted injection is now supported by Dagger and InflationInjection got its own repo. The syntax would now be like :

import dagger.assisted.Assisted
import dagger.assisted.AssistedFactory
import dagger.assisted.AssistedInject
...




class ItemViewModel
@AssistedInject
constructor(private val repo: ItemRepository, @Assisted private val itemId: Long) : ViewModel() {
    init {
        repo.itemId = itemId
    }

    //-@AssistedInject.Factory
    @AssistedFactory
    interface AssistedFactory {
        fun create(@Named("item_id") itemId: Long): ItemViewModel
    }

    companion object {
        fun provideFactory(
            assistedFactory: AssistedFactory,
            itemId: Long
    ): ViewModelProvider.Factory = object : ViewModelProvider.Factory {
         override fun <T : ViewModel?> create(modelClass: Class<T>): T {
             return assistedFactory.create(itemId) as T
         }
       }
    }
}

@InstallIn(FragmentComponent::class)
//-@AssistedModule
@Module
interface AssistedInjectModule {}

@AndroidEntryPoint
class ItemFragment : Fragment() {
    private val args: ItemScreenFragmentArgs by navArgs()      
    @Inject lateinit var itemViewModelAssistedFactory:ItemViewModel.AssistedFactory        
    private val itemViewModel: ItemViewModel by viewModels {
        ItemViewModel.provideFactory(itemViewModelAssistedFactory, args.itemId)
    }    
}

Base on Redek answer. More on that here

score 1 · Answer 4 · answered Dec 14 '20 at 07:52

Actually you can use factory design pattern to create object need item to pass

It's work, but I am not sure it's right way or not

class ItemRepository constructor(private val id: Int) {

}

class RepositoryFactory @Inject constructor() {

    private var id: Int = 0

    fun setId(id: Int) {
        this.id = id
    }

    fun create(): ItemRepository = ItemRepository(id)

}


class ItemViewModel @ViewModelInject constructor(private val repositoryFactory: RepositoryFactory) : ViewModel() {

    private var itemRepository: ItemRepository


    init {
        repositoryFactory.setId(45)
        itemRepository = repositoryFactory.create()
    }

}

@AndroidEntryPoint
class ItemFragment : Fragment() {
    private val viewModel: ItemViewModel by viewModels ()
}

The problem is that the id does not come from the ViewModel, but from the Fragment creating it — John Glen, Jun 13 '22 at 21:55

How to pass runtime parameters to a ViewModel's constructor when using Hilt for dependency injection?

4 Answers4

Linked