java not getting output piglatin

Question

The following is my code for converting all the words of the sentence into PigLatin, ie "Her food is stolen" to "ERHAY OODFAY ISAY OLENSTAY", but the output which I am getting is ERHAY. Any corrections would be appreciated. Thanks.

public class piglatin
{
    public void main(String s)
    {
        s=s.toUpperCase();
        s=s+" ";
        
        int l=s.length(); 
        String word="";
        
        int n=0; 
        int w=0;//no of words in s(loop1)
        int wor=0;//no of words loop2
        for(int i=0;i<l;i++)
        {char c=s.charAt(i);
            if(c==' ')
            w++;
            
        }
        
        
        for(int i=0;i<l;i++)
       {  char c=s.charAt(i);
          int m=s.indexOf(' '); //length of first word
           
         
           if(i==0)
         { for(int j=0;j<m;j++)
             {char c1=s.charAt(j);             
              if(c1=='A'||c1=='E'||c1=='I'||c1=='O'||c1=='U')
              {n=j;//index of first vowel
              j=m;}
             }
             word=s.substring(n,m)+s.substring(0,n);
             System.out.print(word+"AY"+" ");
            
         }
         if(c==' '&&wor!=w-1)
         { s=s.substring(m+1,l);
             l=s.length();
             i=0;
             wor++;
         }
            if(wor==w-1)
            i=l+1;
        }
         
    }
}

Arvind Kumar Avinash · Accepted Answer · 2020-11-29T15:53:54.120

You can simplify it greatly by splitting the sentence on whitespace and processing each word of the resulting array.

import java.util.Scanner;

public class Main {
    public static void main(String[] args) {
        Scanner scanner = new Scanner(System.in);
        System.out.print("Enter a sentence: ");
        String s = scanner.nextLine();
        s = s.toUpperCase();
        String[] words = s.split("\\s+");// Split s on whitespace

        // Process each word from words[]
        for (String word : words) {
            int m = word.length(), j;
            for (j = 0; j < word.length(); j++) {
                char c1 = word.charAt(j);
                if (c1 == 'A' || c1 == 'E' || c1 == 'I' || c1 == 'O' || c1 == 'U') {
                    break;
                }
            }
            String translated = word.substring(j, m) + word.substring(0, j);
            System.out.print(translated + "AY" + " ");
        }
    }
}

A sample run:

Enter a sentence: Her food is stolen
ERHAY OODFAY ISAY OLENSTAY

Alternatively, in addition to using String#indexOf(int ch), you can use String#indexOf(String str, int fromIndex) to get all the words of the sentence.

import java.util.Scanner;

public class Main {
    public static void main(String[] args) {
        Scanner scanner = new Scanner(System.in);
        System.out.print("Enter a sentence: ");
        String s = scanner.nextLine();
        s = s.toUpperCase();

        // Start from index, 0
        int fromIndex = 0, lastPositionOfWhitespace = -1;
        for (int i = 0; i < s.length(); i++) {
            int indexOfWhitespace = s.indexOf(' ', fromIndex);
            String word = "";
            if (indexOfWhitespace != -1) {
                lastPositionOfWhitespace = indexOfWhitespace;
                word = s.substring(fromIndex, indexOfWhitespace);
                fromIndex = indexOfWhitespace + 1;
            } else {
                word = s.substring(lastPositionOfWhitespace + 1);// Last word of the sentence
                i = s.length();// To stop further processing of the loop with counter, i
            }

            int m = word.length(), j;
            for (j = 0; j < word.length(); j++) {
                char c1 = word.charAt(j);
                if (c1 == 'A' || c1 == 'E' || c1 == 'I' || c1 == 'O' || c1 == 'U') {
                    break;
                }
            }
            String translated = word.substring(j, m) + word.substring(0, j);
            System.out.print(translated + "AY" + " ");
        }
    }
}

A sample run:

Enter a sentence: Her food is stolen
ERHAY OODFAY ISAY OLENSTAY

java not getting output piglatin

1 Answers1