I have 2 dimensional array and I want to returns true if there are 3 (or more) elements next to each other in one row,

Question

My problem is the if statement doesn't work and I don't know how to solve this question when I run the code always gives me a row score that's mean that there are three elements or more that are the same however this is not correct. extra details hereunder about the question

I have 2-dimensional array and I want to return true if there are 3 (or more) elements next to each other in one row, this is the question: the method returns true if there are 3 (or more) symbols next to each other in one row, otherwise it returns false. To determine ‘3 in a row’ check all rows (one by one), and in each row remember the ‘current candy’ and set a counter to 1. If the next candy is the same (as the previous one) then increase the counter, otherwise reset the counter to 1 and set the ‘current candy’ again. If the counter becomes 3 then you can return true. → Check if there are (>=) 3 symbols adjacent in one row.

This is my Method

how can I improve it?

bool ScoreRowPresent(RegularCandies[,] playingField)
        {

            for (int i = 0; i < playingField.GetLength(0); i++)
            {
                int counter = 1;
                RegularCandies candies = RegularCandies.JellyBean;

                for (int x = 1; x < playingField.GetLength(1); x++)
                {
                    if (candies==playingField[i,0])
                    {
                        counter++;

                    }
                    else
                    {
                        counter = 1;
                        candies = playingField[i, x];
                    }
                    if (counter >= 3)
                    {
                        return true;

                    }

                }

            }
            return false;
        }

Are you experiencing problems with your code, or did you mean to ask on [codereview.stackexchange.com](https://codereview.stackexchange.com/)? — Xerillio, Nov 27 '20 at 16:13
@Xerillio yes my code doesnt work, and I don't know where I made a mistake thats why Im sharing my code so that someone can help me and telling me where I made a mistake ! — Mayez, Nov 27 '20 at 16:20
Please [edit] the question and add some details about what the problem is. Are you getting exceptions? Are you getting some unexpected behaviour that you could explain? — Xerillio, Nov 27 '20 at 16:23
On first look , i belive this link will help you , https://stackoverflow.com/questions/8400028/comparing-two-instances-of-a-class — Biju Kalanjoor, Nov 28 '20 at 05:08

Mitulát báti · Answer 1 · 2020-11-27T17:05:31.863

0

Try with this:

bool ScoreRowPresent(RegularCandies[,] playingField)
{
    for (var row = 0; row < playingField.GetLength(0); row++)
    {
        var candyToCount = playingField[row, 0];

        var counter = 1;

        for (var column = 1; column < playingField.GetLength(1); column++)
        {
            if (playingField[row, column] == candyToCount)
            {
                counter++;
            }
            else
            {
                counter = 1;
                candyToCount = playingField[row, column];
            }

            if (counter >= 3)
            {
                return true;
            }
        }
    }

    return false;
}

Please let me know if this works.

edited Nov 27 '20 at 17:05

answered Nov 27 '20 at 16:46

Mitulát báti

2,086
5
23
37

What's the purpose of adding `maxAdjacentCandyCount`? `counter` should be enough: `if (counter >= 3) return true;` – Xerillio Nov 27 '20 at 16:50
1

@Xerillio you are right! Thank you for warning me. Locally I was trying out an approach when the number of max adjacent columns returned, but I copied the wrong code (fixed now, answer updated). – Mitulát báti Nov 27 '20 at 17:07

I have 2 dimensional array and I want to returns true if there are 3 (or more) elements next to each other in one row,

1 Answers1