PHP Deprecated: Unparenthesized `a ? b : c ? d : e` is deprecated. Use either `(a ? b : c) ? d : e` or `a ? b : (c ? d : e)`

Question

After upgrading PHP version from 7.3 to 7.4 I'm getting one deprecated issue.

[27-Nov-2020 01:14:32 UTC] PHP Deprecated:  Unparenthesized `a ? b : c ? d : e` is deprecated. Use either `(a ? b : c) ? d : e` or `a ? b : (c ? d : e)` in /home/lankalk/public_html/chat/sender.php on line 364

In line 364 and 365 of sender.php has following code:

$img_ext = ($image_sizes[2] == 1)? "gif":
            ($image_sizes[2] == 2) ? "jpg":"png";

Please suggest me code upgrade

Wrap the nested ternary (between jpg and png) in parentheses. — Andrew Li, Nov 27 '20 at 01:34
As the deprecation warning suggests: ```(($(image_sizes[2] == 1)? "gif": ($image_sizes[2] == 2) ? "jpg"): "png";``` if I understand the syntax correctly. — ewokx, Nov 27 '20 at 01:34
@ewong is this fix start with `(($(image_sizes[2] == 1)?` or `((($image_sizes[2] == 1)?` — Udaya Arunakantha, Nov 27 '20 at 02:09
Please tell us what you want this nested ternary to do. At the moment it's unclear as the logic is not correct. — Dharman, Nov 30 '20 at 17:24

score 1 · Answer 1 · answered Nov 30 '20 at 17:30

It looks like you wanted to have something like this:

if ($image_sizes[2] == 1) {
    $img_ext = "gif";
} elseif ($image_sizes[2] == 2) {
    $img_ext = "jpg";
} else {
    $img_ext = "png";
}

However, this is not what your ternary does at the moment. It looks like it was a bug.

If you would like to keep a nested ternary (which is not recommended as the if statement is easier to understand) then you need to use parentheses to specify which condition is first.

$img_ext = $image_sizes[2] == 1
    ? "gif"
    : (
        $image_sizes[2] == 2 // elseif
        ? "jpg"
        : "png" // else
    );

PHP Deprecated: Unparenthesized `a ? b : c ? d : e` is deprecated. Use either `(a ? b : c) ? d : e` or `a ? b : (c ? d : e)`

1 Answers1