My python perfect number function returns invalid data

Question

I finally got the perfect number program that I am writing in Python to work...just not correctly.

I have run the code 3 times and it keeps returning 24 as a perfect number.

def printPerfectNumbers(firstNum, lastNum):
 
   for i in range(firstNum, lastNum +1):
       totalFactors = 0
       for x in range(1, i):
       # Checks if x is a divisor, if true, adds x to totalFactors.
         if(i % x == 0):
             totalFactors = totalFactors + x
             if (totalFactors == i):
                print(i, end = " ")

printPerfectNumbers(1, 1000)

Any advice would be welcome.

Julien · Answer 1 · 2020-11-12T05:54:43.623

3

         if (totalFactors == i):
            print(i, end = " ")

needs to be 2 levels less since you want to check the sum totalFactors only after all possible candidate divisors have been looked at:

def printPerfectNumbers(firstNum, lastNum):
 
   for i in range(firstNum, lastNum +1):
       totalFactors = 0
       for x in range(1, i):
       # Checks if x is a divisor, if true, adds x to totalFactors.
           if(i % x == 0):
               totalFactors = totalFactors + x
       if (totalFactors == i):
           print(i, end = " ")

printPerfectNumbers(1, 1000)

edited Nov 12 '20 at 05:54

answered Nov 12 '20 at 05:50

Julien

13,986
5
29
53

That fixed it. Thank you so much. – WB CS student Nov 12 '20 at 05:53
PS: you should aim to use consistent indentation too... (e.g. always multiples of 4 spaces) – Julien Nov 12 '20 at 05:55

score -1 · Answer 2 · answered Nov 12 '20 at 05:52

-1

That's simple. 1+2+3+4+6+8=24 You should compare the sum and double of the original number after for.

answered Nov 12 '20 at 05:52

tomo_iris427

161
6

My python perfect number function returns invalid data

2 Answers2