Rosrun command not executing python files

Question

The rosrun command is not executing my python file.The command is just getting skipped. I have already made the python script executable using the command sudo chmod +x controller.py. I am not able to run any python file or the rosrun command. Even the python code has no errors. What is the possible issue?I am a newbie to ROS,so please guide me.

controller.py contains the following code:

import rospy
from geometry_msgs.msg import Twist
#from sensor_msgs.msg import LaserScan
from nav_msgs.msg import Odometry
from tf.transformations import euler_from_quaternion
import math


def odom_callback(data):
    global x,y,pose,ebot_theta
    x  = data.pose.pose.orientation.x
    y  = data.pose.pose.orientation.y
    z = data.pose.pose.orientation.z
    w = data.pose.pose.orientation.w
    pose = [data.pose.pose.position.x, data.pose.pose.position.y, euler_from_quaternion([x,y,z,w])[2]]
    ebot_theta=euler_from_quaternion([x,y,z,w])[2]
#def laser_callback(msg):
    #global regions
    #regions = {
     #   'bright':      ,
      #  'fright':  ,
       # 'front':   ,
       # 'fleft':   ,
        #'bleft':       ,
    #}
def Waypoints(t):
    if t == 0:
        h = 0.74
        k = 0.488
    elif t == 1:
        h = 1.42
        k = 1.289   
    elif t == 2:
        h = 1.911
        k = 1.54
    elif t == 3:
        h = 2.45
        k = 1.2
    elif t == 4:
        h = 3.141 
        k = 0 
    elif t == 5:
        h = 3.91 
        k = -1.289
    elif t == 6:
        h = 4.373
        k = -1.54 
    elif t == 7:
        h = 5.02
        k = -1.125
    elif t == 8:
        h = 5.72
        k = -0.297
    elif t == 9:
        h = 6.283
        k = 0 
    else:
        pass
  
    return [h,k]  


def control_loop():
    rospy.init_node('ebot_controller',anonymous=True)
    
    pub = rospy.Publisher('/cmd_vel', Twist, queue_size=10)
    #rospy.Subscriber('/ebot/laser/scan', LaserScan, laser_callback)
    rospy.Subscriber('/odom', Odometry, odom_callback)
    
    rate = rospy.Rate(10) 

    velocity_msg = Twist()
    velocity_msg.linear.x = 0
    velocity_msg.angular.z = 0
    pub.publish(velocity_msg)
    i=0
    while not rospy.is_shutdown() & i<10:
        
        [x1,y1]=[x,y]
        [x2,y2]=Waypoints(i)
    
        theta_goal= math.atan((y2-y1)/(x2-x1))
        e_theta= ebot_theta-theta_goal
        velocity_msg.linear.x = 10
        velocity_msg.angular.z = (-1)*e_theta
        pub.publish(velocity_msg)
        i=i+1
        print("Controller message pushed at {}".format(rospy.get_time()))
        rate.sleep()
if __name__ == '__control_loop__':
    try:
        control_loop()
    except rospy.ROSInterruptException:
        pass

Here's the screenshot.

score 2 · Answer 1 · edited Nov 02 '20 at 10:50

2

#!/usr/bin/env python

add this line mate;)

edited Nov 02 '20 at 10:50

jottbe

4,228
1
15
31

answered Nov 02 '20 at 07:10

tej

21
1

1

.. explain for dummies... the "WHY"; it prevents down-voting and flagging by bots. – ZF007 Nov 02 '20 at 11:56
Had been struggling with this issue for more than 2 days ;_;. Thanks a lot. I had missed the " python" part. – nik_97 Nov 02 '22 at 05:35

Christian Fritz · Accepted Answer · 2020-10-29T20:00:06.393

0

Your python script doesn't actually run anything. Its main function is empty so to speak.

if __name__ == '__control_loop__':

needs to be

if __name__ == '__main__':

See https://docs.python.org/3/library/__main__.html.

The other thing that is wrong is your use of & when you probably meant and:

>>> False & 0<10
True
>>> False and 0<10
False

So change:

    while not rospy.is_shutdown() & i<10:

to

    while not rospy.is_shutdown() and i<10:

You will also need to add a spin_once into your loop. Otherwise none of the ROS communication will be processed.

edited Oct 29 '20 at 20:00

answered Oct 29 '20 at 18:04

Christian Fritz

20,641
3
42
71

Thanks I changed this part ,but still I am facing the same issue.Do you think there is some error in the code – Vishy2001 Oct 29 '20 at 19:18

Rosrun command not executing python files

2 Answers2