Viewbinding in Fragment causes KotlinNullPointerException running within lifecycle scoped coroutine

Question

I am setting up my Fragment like suggested in Google docs as such:

    private var _binding: MyBinding? = null
    private val binding get() = _binding!!

    override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
        _binding = MyBinding.inflate(inflater, container, false)

    override fun onDestroyView() {
        super.onDestroyView()
        _binding = null
    }

Now I'm calling a coroutine that to my understanding should be scoped to the lifecycle of this fragment. It has a longer network call, then a success:

        lifecycleScope.launch(Dispatchers.Main) {
            when (myViewModel.loadFromNetwork(url)) {
                true -> responseSuccess()
                false -> responseFailure()
            }
        }

    private suspend fun responseSuccess() {
        binding.stateSuccess.visibility = View.VISIBLE
        // ...
    }

Now when I press the Android system-back button while loadFromNetwork is still loading the fragment gets destroyed and onDestroyView() is called. As such binding now is null. I'm getting a kotlin.KotlinNullPointerException. What I not quite getting is why responseSuccess() is still being executed even though I thought that lifecycleScope is specifically meant for these kind of situations. According to Google Docs:

A LifecycleScope is defined for each Lifecycle object. Any coroutine launched in this scope is canceled when the Lifecycle is destroyed.

I understand this code can be fixed by a few changes and some manual null-checks, but I would like to understand how to fix this without boilerplate and in the intended manner. What is the purpose of using lifecycleScope to be lifecycle aware if not exactly this?

what sort of a suspend function is myViewModel.loadFromNetwork() ?? is it a cancellable suspend function? — Ramees Thattarath, Mar 13 '21 at 14:00

esentsov · Accepted Answer · 2021-03-14T17:51:28.410

Coroutines cancellation is cooperative. It means it's a responsibility of a coroutine itself to check for cancellation. Most (or may be all) suspend operations in the coroutines library check for cancellation, but if you don't call any of them, you need to make your code cancellable as described here.

A better option to work with views in coroutines is to use lifecycle extensions which suspend / cancel the coroutine automatically when the lifecycle state is not in a required state.

Also please note, that cancellation is just a regular CancellationException, so check you don't accidentally catch it.

score 1 · Answer 2 · answered Mar 15 '21 at 06:38

well it may not be a very clean way of handling it but I suggest to cancel the job in onDestroyView by your own self
define a job in class level like

lateinit var job:Job

then assign it like

job = lifecycleScope.launch(Dispatchers.Main) {
            when (myViewModel.loadFromNetwork(url)) {
                true -> responseSuccess()
                false -> responseFailure()
            }

and cancel it in onDestroView method before assigning null to _binding.

override fun onDestroyView() {
        super.onDestroyView()
        job.cancel()
        _binding = null
    }

the reason you get NULL POINTER EXCEPTION is that fragments have two lifecycles. 1)lifecycle and view lifecycle. _binding is assigned to null in onDestroyView but fragment lifecycle is still alive so coroutine's job is doing its work, when the network response arrives it run the launch block and wants to access binding object which is null by that time.

Not the exact same issue, but your comment helped me to solve mine. Thanks <3 — Waheed Akhtar, Jan 28 '22 at 14:57

score 0 · Answer 3 · answered Oct 13 '20 at 10:46

0

You are using lifecycleScope which is different to lifecycle of the fragment's view. So you have to use different scope viewLifecycleOwner.lifecycleScope.launch {}. Btw, the link to Google Docs exactly says so :)

answered Oct 13 '20 at 10:46

hrach

2,443
2
26
37

I had the same suspicion when I was reading through the docs again. I think they are both pointing to the same thing, but just to make sure I have verified that the crash happens using `viewLifecycleOwner.lifecycleScope.launch {}` as well. – A1m Oct 13 '20 at 17:39
I am facing the same issue. Is there any fix? – Jeffrey Nyauke Feb 18 '21 at 13:55
Have you tried removing the _binding = null form the onDestroyView? – Jeffrey Nyauke Feb 19 '21 at 12:09
This would solve the issue but it would create a memory leak? – A1m Mar 08 '21 at 19:18

Viewbinding in Fragment causes KotlinNullPointerException running within lifecycle scoped coroutine

3 Answers3