Sorting on the component side vs the reducer in ngrx

Question

I'm using ngrx with angular 9 in my web app. Currently im using the sortCompare function in the reducer like this:

export const adapter : EntityAdapter<Visitor> = createEntityAdapter<Visitor>({
    sortComparer: sortByLastMessage
});

All is good, however im wondering whether i should be sorting on the component side along with *ngFor loop, or keep it in the reducer. Just a question regarding the best practice.

How are you going to to the sorting in the component? using Pipe? — Rafi Henig, Sep 13 '20 at 22:36
not necessarily using pipe, i can select from the store and then sort the returned variable and hand it over to the component and the ngfor loop — Yehia A.Salam, Sep 14 '20 at 06:04

score 2 · Accepted Answer · answered Sep 14 '20 at 17:35

I wouldn't sort the state in the reducer. The selector is the right place for it (in most of the cases). The state can contain the sort config (which property and which sort order), but the logic to sort the entities should not live in the reducer imho.

https://github.com/ngrx/platform/issues/898#issuecomment-379655317

Sorting on the component side vs the reducer in ngrx

1 Answers1