1

I want to write junit test for my gateway cloud filter but problem is i am new on unit test. please help me. and here is one private method for authorization.

[If anyone not know how to write spring Gateway cloud Filter then please go through my gateway filter method. and logic ]

@Component
@Slf4j
public class AuthorizationFilter extends AbstractGatewayFilterFactory<AuthorizationFilter.Config> {

    @Value("${rest.auth.service.url}")
    private String authServiceUrl;

    @Autowired
    RestTemplate restTemplate;

    public AuthorizationFilter() {
        super(Config.class);
    }

    private Mono<Void> onError(ServerWebExchange exchange, String err, HttpStatus httpStatus) {
        ServerHttpResponse response = exchange.getResponse();
        response.setStatusCode(httpStatus);

        return response.setComplete();
    }
    //Here is my authorization details 
    private UserRoleDetailsDTO getAuthorizationDetails(String authorizationHeader) {
        try {
            log.error("Checking authorization");
            HttpEntity<?> entity = new HttpEntity(null, new HttpHeaders() {{
                add("Authorization", authorizationHeader);
                add("Accept", "application/json");
            }});

            ResponseEntity<Map> responseMap = restTemplate.exchange(authServiceUrl.concat("/v1/profile"), HttpMethod.GET, entity, Map.class);
            System.out.println(responseMap);
            if (responseMap.getBody() == null)
                log.warn("Received null body in response. Request will end now");
            Map data = (Map) responseMap.getBody().get("data");
            boolean isAuthorized = data.get("authorized") == null || (boolean) data.get("authorized");
            UserRoleDetailsDTO userRoleDetailsDTO = UserRoleDetailsDTO.builder().userId(String.valueOf(data.get("userId"))).
                    roles((List<RoleDTO>) data.get("roles")).isAuthorized(isAuthorized).build();
            return userRoleDetailsDTO;
        } catch (RestClientException e) {
            String errorResponse = null;
            if (e instanceof HttpClientErrorException) {
                HttpClientErrorException exception = (HttpClientErrorException) e;
                errorResponse = exception.getResponseBodyAsString();
            } else errorResponse = e.getMessage();
            log.error("error with http connect with error response : {} : {}", errorResponse, e);
            return null;
        } catch (Exception e) {
            log.error("error with http connect : {}", e);
            return null;
        }
    }
    // Here is my Gateway filter
    @Override
    public GatewayFilter apply(Config config) {

        return (exchange, chain) -> {
            ServerHttpRequest request = exchange.getRequest();

            String requestId;
            if (request.getHeaders().containsKey("Request-Id")) {
                requestId = request.getHeaders().get("Request-Id").get(0);
            } else {
                requestId = UUID.randomUUID().toString();
                log.debug("Request Id not passed. {} is genertaing requestId {}", AuthorizationFilter.class.getSimpleName(), requestId);
            }
            MDC.put("requestId", requestId);
            request.mutate().header("Request-Id", requestId);

            if (!request.getHeaders().containsKey("Authorization")) {
                log.error("No authorization header");
                return onError(exchange, "No Authorization header", HttpStatus.UNAUTHORIZED);
            }

            String authorizationHeader = request.getHeaders().get("Authorization").get(0);

            UserRoleDetailsDTO userRoleDetailsDTO = getAuthorizationDetails(authorizationHeader);
            if (userRoleDetailsDTO == null || !userRoleDetailsDTO.isAuthorized()) {
                log.error("Invalid authorization header");
                return onError(exchange, "Invalid Authorization header", HttpStatus.UNAUTHORIZED);
            }
            String userDetailsStr = "";
            try {
                userDetailsStr = new ObjectMapper().writeValueAsString(userRoleDetailsDTO);
                System.out.println("value 1 :"+userDetailsStr);
            } catch (JsonProcessingException e) {
                log.error("Exception writing user details to string. ", e);
            }
            if (StringUtils.isEmpty(userDetailsStr))
                log.warn("Empty User Details string being passed!!");
            request.mutate().header(ApplicationConstants.USER_DETAILS_HEADER, userDetailsStr);
            System.out.println("value 2 :"+request.mutate().header(ApplicationConstants.USER_DETAILS_HEADER, userDetailsStr));
            return chain.filter(exchange.mutate().request(request).build());
        };

    }

    @Override
    public Config newConfig() {
        return new Config();
    }

    public static class Config {
        // Put the configuration properties
    }

}

here is my user role details

public class UserRoleDetailsDTO {
    private String userId;
    private List<RoleDTO> roles;
    private boolean isAuthorized = true;
} 

and RoleDto class

  public class RoleDTO {
        private String name;
        private int weight;
    }

here is my junit test when I run with code coverage then I am not getting fully code coverage please help me

 public YourClassTest{   

    @Test
    void apply() throws Exception {
        AuthorizationFilter authorizationFilter  = new AuthorizationFilter();
        AuthorizationFilter.Config config = new YourClass.Config();
        GatewayFilter filter =authorizationFilter.apply(config);
        String st ;
        st = new  ObjectMapper().writeValueAsString(userRoleDetailsDTO);
             MockServerHttpRequest expected  = MockServerHttpRequest.get("/v1/profile").
               header("Authorization", "Bearer sdfsf",st, TestConstants.USER_DETAILS_HEADER).build();
        MockServerWebExchange exchange = MockServerWebExchange.from(expected);
        filter.filter(exchange,FilterChain);
        String requestid;
        ServerHttpRequest actual =  exchange.getRequest();
        assertEquals(expected,actual);
    }
 }
sonu soni
  • 51
  • 2
  • 8
  • You should update the title to say help me get full code coverage in a unit test. As the title appears to be that you need help writing a test. Because of if statements and exception handling you'll likely need multiple tests with different mock requests to get full coverage. – spencergibb Aug 12 '20 at 19:50
  • Thanks spencergibb for giving advise – sonu soni Aug 13 '20 at 04:51

1 Answers1

3

I waited for two days that someone would answer my question but no one answered my question but in the end I solved it. and I have used junit5

Here is my correct solution

@SpringBootTest(properties = { "spring.profiles.active=test" })
class AuthorizationFilterTest {

    @Mock
    GatewayFilterChain filterChain;
    @MockBean()
    RestTemplate restTemplate;
    @Autowired
    AuthorizationFilter authorizationFilter = new AuthorizationFilter();
    
    @BeforeAll
    public static void init() {
    userRoleDetailsDTO = new UserRoleDetailsDTO();
    RoleDTO roleDTO = new RoleDTO();
    roleDTO.setName("ADMIN_ROLE");
    roleDTO.setWeight(1);
    userRoleDetailsDTO.setUserId("user::2f840056-e7aa-84m- 68e1-1e2ef697c78b");
    userRoleDetailsDTO.setRoles(Stream.of(roleDTO).collect(Collectors.toList()));

}


    @Test
    void apply()
    {
     AuthorizationFilter.Config config = new AuthorizationFilter.Config();
    Map<String, Object> profile = objectMapper.readValue(TestConstantsTest.ADMIN_PROFILE_RESPONSE, Map.class);
    ResponseEntity<Map> profileMap = ResponseEntity.ok(profile);
    Mockito.when(restTemplate.exchange(Mockito.anyString(), Mockito.any(HttpMethod.class),
            Mockito.any(HttpEntity.class), Mockito.eq(Map.class))).thenReturn(profileMap);
    GatewayFilter filter = authorizationFilter.apply(config);
    MockServerHttpRequest expected = MockServerHttpRequest.post("/v1/profile")
            .header("Authorization", TestConstantsTest.ADMIN_INITIALISE_REQUEST_AUTH_HEADER).build();
    MockServerWebExchange exchange = MockServerWebExchange.from(expected);
    filter.filter(exchange, GatewayfilterChain);
    ServerHttpRequest actual = exchange.getRequest();
    assertEquals(expected, actual);
   
    }

and here is my TestConstant.class

    Class TestConstantTest
    {
         public static final String ADMIN_PROFILE_RESPONSE = "{\n" +
                "   \"code\":\"200\",\n" +
                "   \"data\":{\n" +
                "      \"myroles\":[\n" +
                "         {\n" +
                "            \"name\":\"ADMIN_ROLE\",\n" +
                "            \"weight\":\"1\"\n" +
                "         }\n" +
                "      ],\n" +
                "      \"userId=User\":\"manually-inserted-usser-user-id-normallt-uuid\"\n" +
                "   },\n" +
                "   \"message\":\"Success\",\n" +
                "   \"status\":1\n" +
                " }";
    
        public static final String ADMIN_INITIALISE_REQUEST_AUTH_HEADER ="Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpX" +
                "VCJ9.eyJhdWQiOlsicmVzb3VyY2Utc2VydmVghingbshtYXBpIl0sImV4cCI6MTU5NTI0NDU2MywidXNlcl9uYW1lIj" +
                "oiYzNlMjk0MGEtYzM3ZS0xMWVhLTg3ZDAtMDI0MmFjMTMwMDAzIiwianRpIjoiZTNkZDA1MTEtNDM0NC00MjhiLTk2Z" +
                "WQtYjUzNzU3Y2uytrewqasdY2xpZW50X2lkIjoic3ByaW5nLXNlY3VyaXR5LW9hdXRoMi1yZWFkLXdyaXRlLWNsa" +
                "WVudCIsInNjb3BlIjpbInJlYWQiLCJ3cml0ZSJdfQ.HvbThWCTqs2y9dP87kE31PmPA-EFk3J6HDFyAiEQlsM";
}
sonu soni
  • 51
  • 2
  • 8