function is fired without calling it

Asked Aug 04 '20 at 11:29

Active Aug 04 '20 at 11:34

Viewed 121 times

That's my code when I run it the openFiles function (that needs to be fired only after checkbox is clicked) fires anyway and that obj is the window not the checkbox... why ? how to fix that? what am I missing?

function openFiles(that) {
    alert("have not touched js for a long time :(");
} 

 function checkbox (){          
     var checkbox = document.createElement('input');
     checkbox.type = "checkbox";
     checkbox.name = "chkbox";
     checkbox.id = "chkid" ;
     checkbox.style = "width:50px";
     checkbox.onclick = openFiles(this);                     
}

edited Aug 04 '20 at 11:31

Suraj Rao

29,388
11
94
103

asked Aug 04 '20 at 11:29

Damkulul

1,406
2
25
59

5

In your code, `onclick` doesn't receive a function, but the value returned by the execution of `openFiles(this)` (which is `undefined` in this specific example). – sp00m Aug 04 '20 at 11:31
5

`checkbox.onclick = () => openFiles(this);` – Aug 04 '20 at 11:32
Where are you calling openFile() function ?? – Sumit Yadav Aug 04 '20 at 11:33
1

You need to bind the checkbox not `this`. `checkbox.onclick = openFiles.bind(checkbox)` so you are able to get the checkbox with `this`. Now you can use it `alert(this)` – bill.gates Aug 04 '20 at 11:38
@ChrisG Thanks! but 'this' obj is still the window and not the checkbox – Damkulul Aug 04 '20 at 11:38
Use `checkbox.addEventListener('click', function (e) { openFiles(this); })` instead – Aug 04 '20 at 11:39
1

@Ifaruki thanks just what I was looking for – Damkulul Aug 04 '20 at 11:41

function is fired without calling it

0 Answers0