Laravel when clause is throwing undefined variable

Question

I am trying to make a conditional where, inside a select statement. It is throwing undefined variable 'class_id'. What is going wrong here. The variable class_id got some value but is throwing 'Undefined variable: class_id'.

$class_id = isset($searchData[1]) ? $searchData[1] : '';

\Log::info($class_id);
    
$students = \User::where('role', 'student')
    ->where('fullName', 'like', '%'.$student_name.'%')
    ->orWhere('username', 'like', '%'.$student_name.'%')
    ->orWhere('email', 'like','%'.$student_name.'%')
    ->when($class_id != '',
        function ($q) {
            return $q->where('studentClass', '=', $class_id);
        })
    ->get();

@jewishmoses sorry for my ignorance here, can you please explain a bit more. Thanks — Malaiselvan, Aug 02 '20 at 18:48
Take a look at this: https://stackoverflow.com/a/7885552/11801683 — jewishmoses, Aug 02 '20 at 18:53

Kurt Friars · Accepted Answer · 2020-08-08T16:17:45.070

1

You are using the wrong syntax for when(). You are using it in the perfect scenario, and you can omit initializing the variable above.

Laravel 5.2 -> 5.5

$class_id = isset($searchData[1]) ? $searchData[1] : '';

$students = \User::where('role','student')
    ->where('fullName','like','%'.$student_name.'%')
    ->orWhere('username','like','%'.$student_name.'%')
    ->orWhere('email','like','%'.$student_name.'%')
    ->when($class_id, function ($query) use ($class_id) {
        return $query->where('studentClass','=', $class_id);
    })->get();

Laravel 5.6+

$students = \User::where('role','student')
    ->where('fullName','like','%'.$student_name.'%')
    ->orWhere('username','like','%'.$student_name.'%')
    ->orWhere('email','like','%'.$student_name.'%')
    ->when($searchData[1], function ($query, $class_id) {
        return $query->where('studentClass','=', $class_id);
    })->get();

edited Aug 08 '20 at 16:17

answered Aug 02 '20 at 21:24

Kurt Friars

3,625
2
16
29

ERROR: Symfony\Component\Debug\Exception\FatalThrowableError: Type error: Too few arguments to function App\Http\Controllers\MyController::App\Http\Controllers\{closure}(), 1 passed and exactly 2 expected in E:\xampp\htdocs\myweb\app\Http\Controllers\MyController.php:737. – Malaiselvan Aug 08 '20 at 15:41
https://laravel.com/docs/7.x/queries#conditional-clauses – Kurt Friars Aug 08 '20 at 15:49
Hi, i am following the exact same thing... For me the variable $class_id is a numeric value. I tried hard coded the variable `$class_id=1` right before the select statement and that too throw the sameerror. – Malaiselvan Aug 08 '20 at 15:51
What version of laravel? – Kurt Friars Aug 08 '20 at 15:51
Looks like the syntax changed in between 5.2 and 5.6 – Kurt Friars Aug 08 '20 at 15:53
I am using Laravel 5.2. The link you shared is for DB query, but I am using the Eloquent way. That is only difference. – Malaiselvan Aug 08 '20 at 15:55
No, the issue is that 5.2 does not pass the second argument to the closure – Kurt Friars Aug 08 '20 at 15:56
Also, the Eloquent query builder extends the DB query builder FYI. – Kurt Friars Aug 08 '20 at 16:01

Laravel when clause is throwing undefined variable

1 Answers1