Vertx RxJava Operator iteration not filtering the content

Question

I am reading the content from file, I put some name into the file with new line separator but while reading the file by vertx file-system I am not able to provide the required filter. every-time it print all the data of file.

Here is the code snippet :-

vertx.fileSystem().open("data.txt", new OpenOptions(), handler -> {
                final AsyncFile asyncFile = handler.result();
                final Observable<Buffer> observable = asyncFile.toObservable();
                observable.subscribe(item -> {
                    final String[] split = item.toString().split("\n\r");
                    List<String> list = Arrays.asList(split);
                    final Observable<String> stringObservable = Observable.fromIterable(list);
                    stringObservable
                            .filter(name -> name.toString().startsWith("R"))
                            .take(2)
                            .subscribe(str -> System.out.println(str), err -> System.out.println(err), () -> System.out.println("Inner loop completed"));


                }, error -> System.out.println(error), () -> System.out.println("Completed !!!"));
            });

Internal observable I used after i find out the above observable have all the data of file in one go.

Can you provide input text file as previous answer is perfectly correct. — Pendula, Aug 04 '20 at 08:33
@Pendula file is containing some random names in every new line like Rat \n Ravat \n Romania \n India \n Africa, please \n as new line — Ravat Tailor, Aug 04 '20 at 11:45
My answer works correctly with that input file - it outputs `Rat\nRavat\nCompleted`. — dano, Aug 04 '20 at 13:29

dano · Accepted Answer · 2020-08-04T13:28:34.760

3

This code snippet actually works fine for me if I split on "\n" instead of "\n\r". If you're having issues with it printing everything, my guess is that the first character in the whole file is "R", and then you don't actually have "\n\r" anywhere in the file. So when you try to split, you end up with just one large String that has the whole file in it.

That said, you can simplify this code significantly by using rxOpen instead of open, avoiding the nesting of subscribes, and simplifying how you turn the Buffer into an Observable that emits each line in the Buffer.

Also note that I used RecordParser to split the contents of the file into tokens using the "\n" character as a delimiter. Just directly turning AsyncFile into an Observable<Buffer> using toObservable() could result in a Buffers that cut off partway through a line, which would screw up your parsing.

So putting it all together:

vertx.fileSystem().rxOpen("data.txt", new OpenOptions())
    .flatMapObservable(af -> RecordParser.newDelimited("\n", af).toObservable())
    .map(Buffer::toString)
    .filter(name -> name.startsWith("R"))
    .take(2)
    .subscribe(System.out::println, System.err::println, () -> System.out.println("Completed"));

You go from 13 lines to 6.

edited Aug 04 '20 at 13:28

answered Jul 31 '20 at 16:50

dano

91,354
19
222
219

Are you sure that `buff` contains the whole file, so you do not need to handle a situation when you have loaded just part of the line and `split` is not going to work in this case? – skywall Jul 31 '20 at 18:46
@skywall Ah, yes, I think you're right, a large enough file will likely be split into multiple Buffers. I'll edit my answer. – dano Jul 31 '20 at 19:08
1

@skywall I updated my answer to account for multiple Buffers being returned for one file. – dano Jul 31 '20 at 19:23
@dano, No help still getting the same response none of the operator is working – Ravat Tailor Aug 04 '20 at 05:20
@RavatTailor You need to provide a sample data.txt that isn't working or something then, because the code in your question, and the code in my answer, both work fine for me using the dummy data I came up with for data.txt. – dano Aug 04 '20 at 13:23

Vertx RxJava Operator iteration not filtering the content

1 Answers1