1

We are still learning GITHUB. So, we try something really simple. A coworker created a branch. Then, when the code changes were ready, he created a pull request for me to review. I reviewed the changes and there were no conflict. There were a lot of changes in many files. Then, I used the "Merge and commits" button in the UI to accept the changes and tried to merge. A comment box come up and I typed in some text. The coworker received my text through email. But, then everything disappeared ! There were no error messages of any kind. The branch no longer existed and none of the changes were merged into the master. There was no record of any kind that I could find.

Is there anything that I did wrong ? (We used the free version of GITHUB.)

steppdev
  • 11
  • 1

1 Answers1

0

If you are using GitHub Desktop for accepting the PR, you would want to push your local updated laster branch after accepting the PR.

But if you were using github.col directly, the Web GUI does not have a "Merge and Commit" option. See "Merging a pull request"

https://docs.github.com/assets/images/help/pull_requests/pullrequest-mergebutton.png

VonC
  • 1,262,500
  • 529
  • 4,410
  • 5,250