id not assigned in contact list

Question

I'm trying to make a basic one-page address book without a database, and I wanted to assign ids to the contacts to make them easier to find. However, when I've tried to add contacts, nothing gets assigned. Any help would be appreciated!

function AddressBook() {
  this.contacts = [];
  this.currentId = 0;
}

AddressBook.prototype.addContact = function(contact) {
  contact.id = this.assignID;
  this.contacts.push(contact);
}

AddressBook.prototype.assignID = function() {
  this.currentID += 1;
  return this.currentId;
}

AddressBook.prototype.findContact = function(id) {
  for (let i = 0; i < this.contacts.length; i++) {
    if(this.contacts[i].id == id) { //uses loose equality to leave room for input error
      return this.contacts[i];
    }
  };
  return false;
}

function Contact(firstName, lastName, phoneNumber) {
  this.firstName = firstName;
  this.lastName = lastName;
  this.phoneNumber = phoneNumber;
}

Contact.prototype.fullName = function() {
  return this.firstName + " " + this.lastName;
}

there appears to be a typo: this.currentID is not this.currentId () — e-frank, Jul 21 '20 at 23:16
Did you try to inspect the actual contents of your `AddressBook` instance? — acran, Jul 21 '20 at 23:34

Gean Ribeiro · Answer 1 · 2020-07-22T02:51:08.387

You have defined assignID as a method, but you've used as a property. To your code works, you need change addContact method like the below code:

AddressBook.prototype.addContact = function(contact) {
    contact.id = this.assignID(); //<===== calling like a method not a property
    this.contacts.push(contact);
}

However, note that currentId is a property of one instance. So, you code will ever put 1 to all IDs.

To fix it, you can change currentId to be one class property like this:

AddressBook.currentId

And in all places reference this property with the class name before:

AddressBook.prototype.assignID = function() {
    AddressBook.currentId += 1; //<====== note that in your code you use ID as upper case, different that you have defined it
    return AddressBook.currentId;
}

Using currentId as a class property, all instances of the class will share this property and each call for assignID() will update the shared property and make that the next instance of the class gets one new ID.

The final code should looks like:

function AddressBook() {
    this.contacts = [];
}

AddressBook.currentId = 0;

AddressBook.prototype.addContact = function(contact) {
    contact.id = this.assignID();
    this.contacts.push(contact);
}

AddressBook.prototype.assignID = function() {
    return ++AddressBook.currentId; //here, first currentId is incremented and after it is returned
}

AddressBook.prototype.findContact = function(id) {
    for (let i = 0; i < this.contacts.length; i++) {
        if(this.contacts[i].id == id) { //uses loose equality to leave room for input error
            return this.contacts[i];
        }
    };
    return false;
}

function Contact(firstName, lastName, phoneNumber) {
    this.firstName = firstName;
    this.lastName = lastName;
    this.phoneNumber = phoneNumber;
}

Contact.prototype.fullName = function() {
    return this.firstName + " " + this.lastName;
}

I don't think you need to make `currentId` a class property since you can call `addContact` on a single `AddressBook` instance multiple times to add multiple contacts which would still all get unique IDs — acran, Jul 21 '20 at 23:39
Yes @ecran ... I think that you have reason. But, maybe the better is to put currentId in Contact and not in AddressBook. So, if you have two instances of AddressBook you do not repeat the contact Id. — Gean Ribeiro, Jul 21 '20 at 23:50

score 0 · Answer 2 · answered Jul 21 '20 at 23:09

0

In addition to calling assignId note that you have uppercase D in this.currentID += 1 but lowercase d in the line below that and in the constructor so you should make the uppercase D lowercase

answered Jul 21 '20 at 23:09

jason_r

345
1
11

id not assigned in contact list

2 Answers2