RecyclerView clickListener is not working

Question

I've implemented the recyclerView clicklistener using best practices yet it still isn't working. The recyclerview is loading data from the internet using retrofit and should take users to the site where the article was published below is my code:

NOTE: My RecyclerView is a RecyclerView of Cardviews

RecyclerView Adapter

    public class NewsArticleAdapter extends RecyclerView.Adapter<NewsArticleAdapter.Viewholder> {
    private ArrayList<Article> newsArticles = new ArrayList<>();
    private Context context;
    private OnArticleListener onArticleListener;

    public NewsArticleAdapter(List<Article> newsArticles, Context context, OnArticleListener onArticleListener) {
        this.newsArticles = (ArrayList<Article>) newsArticles;
        this.context = context;
        this.onArticleListener = onArticleListener;
    }

    @NonNull
    @Override
    public Viewholder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
        View view = LayoutInflater.from(parent.getContext()).inflate(R.layout.news_list_item, parent, false);
        Viewholder viewholder = new Viewholder(view, onArticleListener);
        return viewholder;
    }

    @Override
    public void onBindViewHolder(@NonNull Viewholder holder, int position) {
        Article currentArticle = newsArticles.get(position);

        holder.newsHeadline.setText(currentArticle.getTitle());
        Glide.with(context)
                .load(currentArticle.getUrlToImage())
                .placeholder(R.drawable.ic_launcher_foreground)
                .into(holder.newsImage);
        holder.newsContent.setText(currentArticle.getContent());
//        holder.publishedTime.setText(UTCtoLocalDateConverter(currentArticle.getPublishedAt()));


    }

    @Override
    public int getItemCount() {
        return newsArticles.size();
    }

    public class Viewholder extends RecyclerView.ViewHolder implements View.OnClickListener {
        OnArticleListener onArticleClickedListner;
        TextView newsHeadline;
        TextView newsContent;
        //       TextView publishedTime;
        ImageView newsImage;
        ConstraintLayout parentLayout;

        public Viewholder(@NonNull View itemView, OnArticleListener onArticleListener) {
            super(itemView);
            newsHeadline = itemView.findViewById(R.id.news_headline_textView);
            newsContent = itemView.findViewById(R.id.news_content_textView);
//            publishedTime = itemView.findViewById(R.id.published_time_textView);
            newsImage = itemView.findViewById(R.id.news_image_view);
            parentLayout = itemView.findViewById(R.id.list_item_parent_layout);
            onArticleClickedListner = onArticleListener;
            itemView.setOnClickListener(this);
        }

        @Override
        public void onClick(View view) {
            Log.d("RecyclerViewAdapter", "item position clicked: " + getAdapterPosition());
            onArticleClickedListner.onArticleClicked(getAdapterPosition());
        }
    }

    /*RecyclerView onItemClickListenerInterface*/
    public interface OnArticleListener {
        void onArticleClicked(int position);

    }

}

MainActivity (Houses RecyclerView)

public class MainActivity extends AppCompatActivity implements NewsArticleAdapter.OnArticleListener {
private RecyclerView newsRecyclerView;
private NewsArticleAdapter newsAdapter;
private NewsAPI NewsAPI;
private ArrayList<Article> newsArticles;



@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    newsRecyclerView = findViewById(R.id.newsRecyclerView);
    newsAdapter = new NewsArticleAdapter(new ArrayList<Article>(), this, this);
    RecyclerView.LayoutManager layoutManager = new LinearLayoutManager(this);
    newsRecyclerView.setLayoutManager(layoutManager);
    newsRecyclerView.setAdapter(newsAdapter);


    Retrofit retrofit = new Retrofit.Builder()
            .baseUrl(RetrofitClient.BASE_URL)
            .addConverterFactory(GsonConverterFactory.create())
            .build();

    NewsAPI = retrofit.create(NewsAPI.class);

    Call<Example> call = NewsAPI.getRootJSONObject();

    call.enqueue(new Callback<Example>() {
        @Override
        public void onResponse(Call<Example> call, Response<Example> response) {
            if (response.isSuccessful()) {
                newsArticles = (ArrayList<Article>) response.body().getArticles();
                refreshAdapterWithNewsArticles(newsArticles);
            } else {
                Log.d("MainActivity", "Error in on Response " + String.valueOf(response.code()));
            }
        }

        @Override
        public void onFailure(Call<Example> call, Throwable t) {
            Toast.makeText(MainActivity.this, "Error retrieving News Articles :(", Toast.LENGTH_SHORT).show();
        }
    });


}
/*
 *Method used to generate list of data using recyclerView with costom adapter
 *  */
private void refreshAdapterWithNewsArticles(List<Article> body) {
    newsAdapter = null;
    newsAdapter = new NewsArticleAdapter(body, this, MainActivity.this);
    newsRecyclerView.setAdapter(newsAdapter);

}

@Override
public void onArticleClicked(int position) {
    Log.d("MainActivity", "onArticleClicked Was called in MainACtivity");
    Article currentArticle = newsArticles.get(position);
    Uri articleUri = Uri.parse(currentArticle.getUrl());
    Intent intent = new Intent(Intent.ACTION_VIEW, articleUri);
    startActivity(intent);
}

}

Answer 1

Inspired by the code provided in this answer from Jacob Tabak, in your mainActivity under onCreate method.

recyclerView.addOnItemTouchListener(new RecyclerItemClickListener(MainActivity.this, recyclerView, new RecyclerItemClickListener.OnItemClickListener() {
        @Override
        public void onItemClick(View view, int position) {
            //whatever you want to do with position
        }

        @Override
        public void onLongItemClick(View view, int position) {
            //whatever you want to do with position
        }
    }));

and create a new class name it RecyclerItemClickListener and paste this

public class RecyclerItemClickListener implements RecyclerView.OnItemTouchListener {
GestureDetector mGestureDetector;
private OnItemClickListener mListener;

public RecyclerItemClickListener(Context context, final RecyclerView recyclerView, OnItemClickListener listener) {
    mListener = listener;
    mGestureDetector = new GestureDetector(context, new GestureDetector.SimpleOnGestureListener() {
        @Override
        public boolean onSingleTapUp(MotionEvent e) {
            return true;
        }

        @Override
        public void onLongPress(MotionEvent e) {
            View child = recyclerView.findChildViewUnder(e.getX(), e.getY());
            if (child != null && mListener != null) {
                mListener.onLongItemClick(child, recyclerView.getChildAdapterPosition(child));
            }
        }
    });
}

@Override
public boolean onInterceptTouchEvent(RecyclerView view, MotionEvent e) {
    View childView = view.findChildViewUnder(e.getX(), e.getY());
    if (childView != null && mListener != null && mGestureDetector.onTouchEvent(e)) {
        mListener.onItemClick(childView, view.getChildAdapterPosition(childView));
        return true;
    }
    return false;
}

@Override
public void onTouchEvent(RecyclerView view, MotionEvent motionEvent) {
}

@Override
public void onRequestDisallowInterceptTouchEvent(boolean disallowIntercept) {
}

public interface OnItemClickListener {
    public void onItemClick(View view, int position);

    public void onLongItemClick(View view, int position);
}}

It is a custom RecyclerItemClickListener.

Answer 2

Why don't you try the listener from the onBindViewHolder() method?

holder.your_layout_item.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            onArticleClickedListner.onArticleClicked(position);
        }
    });

If you have any confusion I can explain it more clear. If you solved it you can accept the answer.