JUnit5 assertAll private method assertions being ignored

Question

Using JUnit5 assertAll, I call a method to perform assertions but noticed that when the assertion should fail, the test actually passes. It seems calling a method like the below is being ignored.

assertAll(
    () -> jsonAssertions(actual, expectedUrl)
);

private Executable[] jsonAssertions(String actual, String expectedUrl) {
    return new Executable[] {
        () -> ProductAssert.assertThat(actual).urlEquals(expectedUrl)
    };
}

(ProductAssert is a custom assertJ assertion class).

This works fine though

assertAll(
    () -> ProductAssert.assertThat(actual).urlEquals(expectedUrl)
);

Please [edit] your question to include the source code you have as a [mcve], which can be compiled and tested by others. — Progman, Jul 18 '20 at 16:46

blacktide · Accepted Answer · 2020-07-18T17:42:08.053

0

JUnit 5 assertAll takes a list of Executable instances.

The way you're doing it now, you're not actually passing the Executable list to assertAll. Instead of passing an anonymous method to assertAll, pass the results of jsonAssertions directly:

@Test
private void test() {
    assertAll(jsonAssertions(actual, expected));
}

private Executable[] jsonAssertions(String actual, String expected) {
    return new Executable[] {
        () -> assertThat(actual).isNotNull(),
        () -> assertThat(expected).isNotNull(),
        () -> assertThat(actual).isEqualTo(expected)
    };
}

edited Jul 18 '20 at 17:42

answered Jul 18 '20 at 17:21

blacktide

10,654
8
33
53

So what changes do I need to make to the method: – Ilyas Patel Jul 18 '20 at 17:35
private Executable[] jsonAssertions(String actual, String expectedUrl) { return new Executable[] { () -> ProductAssert.assertThat(actual).urlEquals(expectedUrl) }; } – Ilyas Patel Jul 18 '20 at 17:35
You don't need any changes to your `jsonAssertions` method, just remove the `() ->` from your `assertAll` call. – blacktide Jul 18 '20 at 17:38
@IlyasPatel updated the answer with a more complete example. – blacktide Jul 18 '20 at 17:42

JUnit5 assertAll private method assertions being ignored

1 Answers1