How to solve Oscommerce, Warning: sizeof(): Parameter must be an array or an object that implements Countable

Question

I install the latest version of OSCommerce framework. in backend Categories/Products error shown like:

Warning: sizeof(): Parameter must be an array or an object that implements Countable in C:\xampp\htdocs\oscommerce\catalog\admin\includes\functions\general.php on line 93

I try to use is_array() and count() but still not working, below are the code

    function tep_get_path($current_category_id = '') {
    global $cPath_array;

    if ($current_category_id == '') {
      $cPath_new = implode('_', $cPath_array);
    } else {
      if (sizeof($cPath_array) == 0) {
        $cPath_new = $current_category_id;
      } else {
        $cPath_new = '';
        $last_category_query = tep_db_query("select parent_id from " . TABLE_CATEGORIES . " where 
        categories_id = '" . (int)$cPath_array[(sizeof($cPath_array)-1)] . "'");
        $last_category = tep_db_fetch_array($last_category_query);

        $current_category_query = tep_db_query("select parent_id from " . TABLE_CATEGORIES . " where 
        categories_id = '" . (int)$current_category_id . "'");
        $current_category = tep_db_fetch_array($current_category_query);

        if ($last_category['parent_id'] == $current_category['parent_id']) {
          for ($i = 0, $n = sizeof($cPath_array) - 1; $i < $n; $i++) {
            $cPath_new .= '_' . $cPath_array[$i];
          }
        } else {
          for ($i = 0, $n = sizeof($cPath_array); $i < $n; $i++) {
            $cPath_new .= '_' . $cPath_array[$i];
          }
        }

        $cPath_new .= '_' . $current_category_id;

        if (substr($cPath_new, 0, 1) == '_') {
          $cPath_new = substr($cPath_new, 1);
        }
      }
    }

    return 'cPath=' . $cPath_new;
  }

score 3 · Answer 1 · edited Feb 28 '21 at 09:01

3

I added below code in the file just the line which was giving the error.

if ($cPath_array == null) {
    $cPath_array = array();
}

It has resolved my error

edited Feb 28 '21 at 09:01

Syscall

19,327
10
37
52

answered Feb 27 '21 at 18:01

Anuradha Korde

31
5

score 1 · Answer 2 · answered Jul 13 '20 at 07:45

sizeof is an alias of count.

count's behavior changed in Php 7.2.

count() will now yield a warning on invalid countable types passed to the array_or_countable parameter.

Possible causes:

var_dump(count([])); // OK
var_dump(count((object)[])); // Warning
var_dump(count(null)); // Warning
var_dump(count(false)); // Warning
var_dump(count(123)); // Warning
var_dump(count('123')); // Warning

Please check the data type of $cPath_array using var_dump. $cPath_array is implemented as array in the code but whats its actual value for which warning is generated.

Bad and Temporary solution: Downgrade your Php version.

score 0 · Answer 3 · answered Feb 28 '21 at 08:59

0

You could also use empty(). It checks if a variable is "falsy".

if (empty($cPath_array)) { }

Instead of

if (sizeof($cPath_array) == 0) { }

answered Feb 28 '21 at 08:59

Syscall

19,327
10
37
52

How to solve Oscommerce, Warning: sizeof(): Parameter must be an array or an object that implements Countable

3 Answers3