Is there any way I can shorten properties with similar statements but different returns?

Question

class....

    @property
    def degrees(self):
        hem, degs, mins, secs = self._correction()
        return degs

    @property
    def minutes(self):
        hem, degs, mins, secs = self._correction()
        return mins

    @property
    def seconds(self):
        hem, degs, mins, secs = self._correction()
        return secs

I was thinking that def could be truncated like:

@property
def hemisphere, degrees, minutes, seconds(self):
    hem, degs, mins, secs = self._correction()
    return hem, degs, mins, secs

so that when I call 'hemisphere' it will return hem values and so on.

PS. I know that my return statement in the latter was wrong. I hope you get my point.

You could do `return self._correction()[0]` but that is about all — xjcl, Jul 12 '20 at 14:06
This seems a much simpler and more obvious solution than any of the answers. — DisappointedByUnaccountableMod, Jul 12 '20 at 14:22
do you really need `@property` ? It would be simpler to do `self.hem, self.degs, self.mins, self.secs = self._correction()` in `__init__` — furas, Jul 12 '20 at 14:51
You may think about accepting an answer to reward those how helped you, or at least comment to explain what's missing ;) — azro, Jul 19 '20 at 12:50

score 0 · Answer 1 · answered Jul 12 '20 at 14:09

0

You could override __getattr__ method

def __getattr__(self, item):
    values = ["hemisphere", "degrees", "minutes", "seconds"]
    if item in values:
        return self._correction()[values.index(item)]
    raise AttributeError(f"'{self.__class__.__name__}' object has no attribute '{item}'")

answered Jul 12 '20 at 14:09

azro

53,056
7
34
70

This seems like a complicated and totally non-obvious way of trying to address the question. – DisappointedByUnaccountableMod Jul 14 '20 at 18:35
@barny Feel free to provide an answer so ;) – azro Jul 14 '20 at 18:40
@xjcl already did in their comment on the question. – DisappointedByUnaccountableMod Jul 14 '20 at 20:17

L3viathan · Answer 2 · 2020-07-12T14:18:19.280

0

There's a bunch of ways you could shorten this, I would write another helper function:

from functools import wraps

def unpack(rng, fn, propertize=False):
    for i in rng:
        @wraps(fn)
        def wrapper(*args, __i=i, **kwargs):
            return fn(*args, **kwargs)[i]
        yield property(wrapper) if propertize else wrapper

...

class Something:
    hemisphere, degrees, minutes, seconds = unpack(
        range(4), Something._correction, propertize=True
    )

edited Jul 12 '20 at 14:18

answered Jul 12 '20 at 14:10

L3viathan

26,748
2
58
81

This also seems like a complicated and totally non-obvious way of trying to address the question. – DisappointedByUnaccountableMod Jul 14 '20 at 18:35

score 0 · Accepted Answer · answered Jul 15 '20 at 10:57

0

As @xjcl commented, and on the basis of simplicity in preference to seemingly unecessary complication/obfuscation:

class....

    @property
    def degrees(self):
        return self._correction()[1]

    @property
    def minutes(self):
        return self._correction()[2]

    @property
    def seconds(self):
        return self._correction()[3]

answered Jul 15 '20 at 10:57

DisappointedByUnaccountableMod

6,656
4
18
22

this is actually the answer i need. Thank you – yuukiroh Jul 18 '20 at 14:15

Is there any way I can shorten properties with similar statements but different returns?

3 Answers3