Code returns all members and not the members in the role

Question

This is the code:

let getMembers = message.guild.members.cache.filter(member => {
    return message.guild.roles.fetch('701142571623252018');
}).map(member => {
    return member.user.username;
});

It returns all members in the server, but not the members in the specific role, which it is supposed to do.

This is my full code:

    const targetRole = message.guild.roles.cache.get('701142571623252018');
    if (!targetRole) return console.log('No role found')
    const members = message.guild.members.cache.filter((member) => !member.roles.cache.some((role) => role.id === targetRole.id)).map(m => m.user.username)

    const players = new Discord.MessageEmbed()
      .setColor('#6B238E')
      .setTitle("Players:")
      .setDescription(members);

    message.channel.send(players);
    //console.log(members);

and what is the content of message.guild ? – Hendra Jun 10 '20 at 16:14 — Hendra, Jun 10 '20 at 16:14
what if you map and then filter? – innis Jun 10 '20 at 16:16 — innis, Jun 10 '20 at 16:16
Would I just switch the two? – Johonny Jun 10 '20 at 16:20 — Johonny, Jun 10 '20 at 16:20

score 2 · Accepted Answer · answered Jun 10 '20 at 16:23

That's because your filter function is not returning whether the member has the role or not: it's returning a Promise which should resolve into a Role, which is interpreted as true and so everything passes the filter.

You don't actually need to fetch the role, since you only need to check if that ID is one of the roles from of the member: to do that you can use GuildMember.roles.cache.has(), which will return whether the roles collection has a role with that ID.

Here's how you can do it:

message.guild.members.cache.filter(member => member.roles.cache.has('701142571623252018'))
  .map(member => member.user.username)

Cipher · Answer 2 · 2020-06-10T19:32:53.070

0

You can use filter and method collection.some for check if member has role.

bot.on('message', (message) => {
    const targetRole = message.guild.roles.cache.get('ROLE ID');
    if (!targetRole) return console.log('No role found')
    const members = message.guild.members.cache.filter((member) => member.roles.cache.some((role) => role.id === targetRole.id)).map(m => m.user.username)
});

V2

const Discord = require('discord.js')
const bot = new Discord.Client();

bot.on('message', (message) => {
    const targetRole = message.guild.roles.cache.get('648157497051447317');
    if (!targetRole) return console.log('No role found')
    const members = message.guild.members.cache.filter((member) => member.roles.cache.some((role) => role.id === targetRole.id)).map(m => m.user.username)
    console.log(members)
});

bot.login('TOKEN HERE')

edited Jun 10 '20 at 19:32

answered Jun 10 '20 at 16:24

Cipher

2,702
1
6
17

When I try to console.log(members), it doesn't do anything – Johonny Jun 10 '20 at 16:43
I check it, its works fine. Are you sure you login you bot and send message ? – Cipher Jun 10 '20 at 16:56
Oh, 1 qestion, you need members who has role ? Or all members without some role ? – Cipher Jun 10 '20 at 16:58
My bad, I was starting the wrong bot lol. It still says everybody and not just the people who have the role. – Johonny Jun 10 '20 at 17:01
I need all of the members who have that specific role – Johonny Jun 10 '20 at 17:11
Can you help me with this? – Johonny Jun 10 '20 at 18:23
So its right answer https://stackoverflow.com/a/62308398/12590637 You can use this code – Cipher Jun 10 '20 at 19:32

Code returns all members and not the members in the role

2 Answers2

V2

Linked