0

I have this function

int APIENTRY _tWinMain(HINSTANCE hInstance,
                 HINSTANCE hPrevInstance,
                 LPTSTR    lpCmdLine,
                 int       nCmdShow)
{
UNREFERENCED_PARAMETER(hPrevInstance);
UNREFERENCED_PARAMETER(lpCmdLine);

// TODO: Place code here.
MSG     msg;
HACCEL  hAccelTable;
int     i;
DWORD   dwThreadIdArray[NUM_THREADS]; //edited after first post
Gdiplus::GdiplusStartupInput gdiplusStartupInput;
ULONG_PTR gdiplusToken;
PARAM_PASSED *paramPassed = NULL;
std::ostringstream ss;
std::wstring str;

// Initialize global strings
LoadString(hInstance, IDS_APP_TITLE, szTitle, MAX_LOADSTRING);
LoadString(hInstance, IDC_LSP3, szWindowClass, MAX_LOADSTRING);
MyRegisterClass(hInstance);

// Perform application initialization:
if (!InitInstance (hInstance, nCmdShow))
{
    return FALSE;
}

hAccelTable = LoadAccelerators(hInstance, MAKEINTRESOURCE(IDC_LSP3));

// Initialize GDI+ 
GdiplusStartup( &gdiplusToken, &gdiplusStartupInput, NULL); 

// Create event in order to let the other threads know
// when they can start posting message
hStartEvent = CreateEvent(  NULL,                   // default security attributes
                            TRUE,                   // manual-reset event
                            FALSE,                  // initial state is nonsignaled
                            TEXT("StartEvent"));    // object name

if(hStartEvent == NULL)
{
    ss << "_tWinMain: CreateEvent failed" << std::endl;
    str = string2wideString(ss.str().c_str()); 
    OutputDebugString(str.c_str());
    return 1;
}

// Create threads
for(i = 0; i < NUM_THREADS; i++)
{
    paramPassed = NULL;
    threadHandles[i] = CreateThread(NULL,                   // security context is default 
                                    0,                      // stack size is default
                                    rectAnalyzer,           // start routine is rectAnalyzer
                                    paramPassed,            // parameter pointer is paramPassed 
                                    0,                      // thread active
                                    &dwThreadIdArray[i]);   // variable used to store thread id
    if(threadHandles[i] == NULL)
    {
        ss << "_tWinMain: error CreateThread " << i << std::endl;
        str = string2wideString(ss.str().c_str()); 
        OutputDebugString(str.c_str());
    }
    else
    {
        ss << "_tWinMain: created thread " << i << std::endl;
        str = string2wideString(ss.str().c_str()); 
        OutputDebugString(str.c_str());
    }
}

// Let other threads start
SetEvent(hStartEvent);

// Main message loop:
while (GetMessage(&msg, NULL, 0, 0))
{
    if (!TranslateAccelerator(msg.hwnd, hAccelTable, &msg))
    {
        TranslateMessage(&msg);
        DispatchMessage(&msg);
    }
}

// Wait for all threads
WaitForMultipleObjects(NUM_THREADS, threadHandles, TRUE, INFINITE);

for(i = 0; i < NUM_THREADS; i++)
{
    CloseHandle(threadHandles[i]);
}

//Releases GDI+
Gdiplus::GdiplusShutdown(gdiplusToken);

return (int) msg.wParam;
}

and I get this output:

_tWinMain: created thread 0
_tWinMain: created thread 0
_tWinMain: created thread 1
_tWinMain: created thread 0
_tWinMain: created thread 1
_tWinMain: created thread 2  
_tWinMain: created thread 0
_tWinMain: created thread 1
_tWinMain: created thread 2
_tWinMain: created thread 3
The thread 'Win32 Thread' (0x159c) has exited with code 0 (0x0).
The thread 'Win32 Thread' (0x12bc) has exited with code 0 (0x0).
The thread 'Win32 Thread' (0x102c) has exited with code 0 (0x0).
The thread 'Win32 Thread' (0x1594) has exited with code 0 (0x0).
The thread 'Win32 Thread' (0x107c) has exited with code 1 (0x1).
The program '[2308] lsp3.exe: Native' has exited with code 0 (0x0).

Why am I getting multiple output for thread 0...2 ? I don't know if I am creating 4 threads or 10 threads.. Moreover in the end it seems I created 4 threads plus primary thread..

gc5
  • 9,468
  • 24
  • 90
  • 151

1 Answers1

5

You are not clearing the stringstream ss in the loop, so the output just accumulates:

thread 0
thread 0 1
thread 0 1 2
thread 0 1 2 3

Add a ss.str("") after doing each output.

Bo Persson
  • 90,663
  • 31
  • 146
  • 203