Find the maximum of three integers

Question

I have made a program for finding the greatest of the given three numbers. It works for single digit but it is not working for three digit numbers. Why not?

package practice;
import java.util.Scanner;

public class AllPractice {
    public static void main(String[] args) {
        Scanner sc = new Scanner(System.in);
        int a = sc.nextInt();
        int b = sc.nextInt();
        int c = sc.nextInt();
        if(a > b) {
            if (a > c) {
                System.out.println("maximum of the given numbers "+a);
            }else {
                if (b > a) {
                    if (b > c) {
                        System.out.println("maximum of the given numbers "+b);
                    }
                }else {
                    System.out.println("maximum of the given numbers "+c);
                }
            }
        }
    }
}

What's an example of input that fails, and what is the actual and expected output? — John Kugelman, May 07 '20 at 18:25
It is unclear what you mean by 'not working'. Please add examples of the input and output for success and failure cases. — vsfDawg, May 07 '20 at 18:35
@vsfDawg, I think *'not working'* is in the case where `a < b` and print nothing — thibsc, May 07 '20 at 18:37
Add your numbers to a Collection and then use Collections.max() — HomeIsWhereThePcIs, May 07 '20 at 19:56

thibsc · Answer 1 · 2020-05-07T18:47:21.333

4

Your code doesn't work because if your variable a is smaller than b, you never enter the first condition.

An easy one line solution/alternative:

int max = Collections.max(Arrays.asList(a, b, c));

edited May 07 '20 at 18:47

answered May 07 '20 at 18:31

thibsc

3,747
2
18
38

You can also use `List.of(a, b, c)`. Also possible `IntStream.of(a, b, c).max().orElseThrow()`. And `Math.max(a, Math.max(b, c))`. – Zabuzard May 07 '20 at 18:44

score 1 · Answer 2 · answered May 07 '20 at 18:32

Your program will work only if a is greater than b. If you want to use simple if else below code will work.

if(a>b && a>c )
    System.out.println("maximum of the given numbers "+a);
else if (b>a && b>c)
    System.out.println("maximum of the given numbers "+b);
else 
    System.out.println("maximum of the given numbers "+c);

Find the maximum of three integers

2 Answers2