Can't understand why the code violates Single Responsibility Principle (in book 'clean code' by Robert C. Martin)

Asked Apr 22 '20 at 08:28

Active Apr 22 '20 at 08:31

Viewed 47 times

I'm reading the book 'Clean Code' by Robert C. Martin. The book said code under this paragraph violates Single Responsibility Principle But I don't know why!

Payroll.java

  Public Money calculatePay(Employee e)
  throws InvalidEmployeeType {
    switch (e.type) {
      case COMISSIONED:
        return calculateCommissionedPay(e);
      case HOURLY:
        return calculateHourlyPay(e);
      case SALARIED:
        return calculateSalariedPay(e);
      default:
        throw new InvalidEmployeeType(e.type);
    }
  }

I think 'calculate pay' only has responsibility for CFO. So, I thought this code doesn't violate SRP. However, the book said it's not. Could you help me, please?

edited Apr 22 '20 at 08:31

asked Apr 22 '20 at 08:28

Mint Bee

1

what else does the book say? normally, it'll explain it. – Stultuske Apr 22 '20 at 08:30
It just says 'there are many reasons to change the code.' not specifically explained anymore. – Mint Bee Apr 22 '20 at 08:34
3

Does this answer your question? [Understanding the Single Responsibility Principle](https://stackoverflow.com/questions/33276095/understanding-the-single-responsibility-principle) – geffchang Apr 22 '20 at 08:34
What page is this code listing from? – DasElias Apr 22 '20 at 08:40
I'm reading translated book so, I can't say exactly but the number of code is 3-4. Thanks a lot! – Mint Bee Apr 22 '20 at 08:58

Can't understand why the code violates Single Responsibility Principle (in book 'clean code' by Robert C. Martin)

0 Answers0