I have a problem with Livedata observer called multiple time

Question

This is my CartProductItemDao.

    @Dao
public interface CartProductItemDao {

    @Query("select * from CartProductItem where product__category__id = :id")
    LiveData<List<CartProductItem>> getCartProductItemList(int id);

    @Query("select * from CartProductItem where product__id in (:items)")
    LiveData<List<CartProductItem>> getAllProductsSectionItem(ArrayList<Integer> items);

    @Query("Select * from CartProductItem  where product__fav_market_id =:id")
    LiveData<List<CartProductItem>> geAllCartProductItemList(int id);
}

and this is my CartProductItemRepository.

    public class CartProductItemRepository {
    LiveData<List<CartProductItem>> cartProductItemList;
    CartProductItemDao cartProductItemDao;

    public CartProductItemRepository(Application application) {
        TreaderOnlineDatabase treaderOnlineDatabase=TreaderOnlineDatabase.getInstance(application);
        cartProductItemDao=treaderOnlineDatabase.cartProductItemDao();
    }

    public LiveData<List<CartProductItem>> getCartProductItemList(int cat_id) {
        cartProductItemList= cartProductItemDao.getCartProductItemList(cat_id);
        return cartProductItemList;
    }
}

and this is my CartProductItemViewModel.

    public class CartProductItemViewModel extends AndroidViewModel {
    LiveData<List<CartProductItem>> cartProductItemList;
    LiveData<List<CartProductItem>> productSectionItemList;
    LiveData<List<CartProductItem>> allCartProductItem;
    CartProductItemRepository cartProductItemRepository;

    SharedPreferenceClass sharedPreferenceClass;

    public CartProductItemViewModel(@NonNull Application application) {
        super(application);
        cartProductItemRepository=new CartProductItemRepository(application);
        sharedPreferenceClass=new SharedPreferenceClass(getApplication());
        //cartProductItemList=cartProductItemRepository.getCartProductItemList();
    }

    public LiveData<List<CartProductItem>> getCartProductItemList(int id) {
        cartProductItemList=cartProductItemRepository.getCartProductItemList(id);
        return cartProductItemList;
    }
}

and I called getCartProductItemList(cat_is) from inside fragment and this is the code

    @Override
public void recyclerViewOnClick2() {
    CartProductItemViewModel cartProductItemViewModel;
    cartProductItemViewModel=ViewModelProviders.of(this).get(CartProductItemViewModel.class);
    int x=sharedPreferenceClass.getSharedPreferenceCatId();
    cartProductItemViewModel.getCartProductItemList(x).observe(this, new Observer<List<CartProductItem>>() {
        @Override
        public void onChanged(List<CartProductItem> cartProductItems) {
            product_categoriesFragmentAdpter.setArrayList(cartProductItems, getContext());
        }
    });
}

the problem when I make an update or delete for table or insert this observer called multiple times.

FYI you can use markdown style ``` to mark the begin and end of code blocks. — Doug Stevenson, Mar 29 '20 at 19:31
from where did you calling this method : recyclerViewOnClick2() ?/ make sure you haven't trigger it multiple time as you have this object local : CartProductItemViewModel cartProductItemViewModel; — Nilesh B, Mar 29 '20 at 19:46
I called it from inside RecyclerViewAdapter when the user click on item of RecyclerView. — Saddam Alwaheab, Mar 29 '20 at 19:59
@Nilesh B what do you mean by "make sure you haven't trigger it multiple time as you have this object local "? — Saddam Alwaheab, Mar 30 '20 at 13:48
@SaddamAlwaheab chekc if you are calling this method multiple time. — Nilesh B, Mar 30 '20 at 16:59
@SaddamAlwaheab code for update/delete query is missing. might been issue is there, you should post all related code — Nilesh B, Mar 30 '20 at 17:02

score 4 · Accepted Answer · answered Mar 29 '20 at 21:46

The lifecycle of the Fragment can be longer than the lifecycle of the View created. Replace this with viewLifecycleOwner for observing your liveData to avoid double subscriptions :

cartProductItemViewModel.getCartProductItemList(x).observe(viewLifecycleOwner, new Observer<List<CartProductItem>>() {
    @Override
    public void onChanged(List<CartProductItem> cartProductItems) {
        product_categoriesFragmentAdpter.setArrayList(cartProductItems, getContext());
    }
});

Make sure you don't observe liveData before onCreateView(), when using viewLifecycleOwner.

Source: https://developer.android.com/reference/androidx/fragment/app/Fragment.html#getViewLifecycleOwner()

https://www.youtube.com/watch?v=pErTyQpA390&feature=youtu.be

how can I get viewLifecycleOwner inside fragment to livedata observer — Saddam Alwaheab, Mar 30 '20 at 06:41
@SaddamAlwaheab Every fragment has access to viewLifecycleOwner. As your are using java, you may have to use getViewLifecycleOwner(). — Badhrinath Canessane, Mar 30 '20 at 07:58

I have a problem with Livedata observer called multiple time

1 Answers1