Property 'allSettled' does not exist on type 'PromiseConstructor'.ts(2339)

Question

I'm trying to use the Promise.allSettled API with TypeScript. Code here:

server.test.ts:

it('should partial success if QPS > 50', async () => {
  const requests: any[] = [];
  for (let i = 0; i < 51; i++) {
    requests.push(rp('http://localhost:3000/place'));
  }
  await Promise.allSettled(requests);
  // ...
});

But TSC throws an error:

Property 'allSettled' does not exist on type 'PromiseConstructor'.ts(2339)

I already added these values to the lib option in tsconfig.json:

tsconfig.json:

{
  "compilerOptions": {
    /* Basic Options */
    "target": "ES2015" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */,
    "module": "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */,
    "lib": [
      "ES2015",
      "ES2016",
      "ES2017",
      "ES2018",
      "ES2019",
      "ES2020",
      "ESNext"
    ] 
   // ...
}

TypeScript version: "typescript": "^3.7.3"

So, how can I solve this? I know I can use an alternative module, but I am curious about working with TypeScript natively.

score 45 · Accepted Answer · answered Feb 18 '20 at 07:53

45

The types for Promise.allSettled() were only merged in January, and will apparently be released in TypeScript 3.8.

As an interim solution, you can declare a mock-ish type for the function yourself:

declare interface PromiseConstructor {
    allSettled(promises: Array<Promise<any>>): Promise<Array<{status: 'fulfilled' | 'rejected', value?: any, reason?: any}>>;
}

answered Feb 18 '20 at 07:53

AKX

152,115
15
115
172

1

How do you tell when it will be released? – Josh Wulf Feb 18 '20 at 07:55
1

@JoshWulf Look at the tags for that commit, and you can see that they're for 3.8. Some googling can take you to https://github.com/microsoft/TypeScript/issues/34898 which shows the schedule – CertainPerformance Feb 18 '20 at 07:57
1

@JoshWulf The tag list in the blue header in the GitHub link says "v3.8-rc" and "v3.8-beta" :) – AKX Feb 18 '20 at 07:57
12

I am at 3.9.5 and still it does not have this type, is there something wrong with my env? – oskar132 Jun 30 '20 at 15:37
39

@oskar132 make sure your `tsconfig.json` has the `es2020` in the `lib` array – jmzagorski Jul 10 '20 at 21:11
7

And after changing to `es2020` in `tsconfig.json`, I had to close and reopen VSCode, but it works. Thanks @jmzagorski ! – Cameron Hudson Nov 11 '20 at 02:12
@CameronHudson After you change the `tsconfig.json`, you can "Restart TS server" instead of restart VSCode. – Lin Du Mar 24 '23 at 07:35

Leigh Mathieson · Answer 2 · 2021-01-30T14:53:44.170

To get this running on Linux, I needed the latest typescript version:

npm install -g typescript@latest

Then in your tsconfig you currently need the ES2020.Promise lib. My full tsconfig:

{
  "compilerOptions": {
    "sourceMap": true,
    "module": "commonjs",
    "target": "es5",
    "jsx": "react",
    "esModuleInterop": true,
    "allowJs": true,
    "outDir": "./dist",
    "lib": [
      "ES2020.Promise",
    ]
  },
  "include": [
    "./src"
  ],
  "exclude": [
    "./node_modules",
    "./build"
  ],
  "compileOnSave": true,
  "parserOptions": {
    "ecmaFeatures": {
      "jsx": true
    }
  }
}

Usage: const results = await Promise.allSettled(BatchOfPromises);

Josh Wulf · Answer 3 · 2020-02-18T08:01:10.930

11

It's ES2020 and at Stage 4, so not available everywhere without a polyfill. It got typed and merged into TS. Try installing the latest @types/node package and see if that pulls it in.

Update: Looks like it will be adding es2020.promise to the libs, when it does land.

Update: npm i typescript@3.8.0-beta woot woot!

edited Feb 18 '20 at 08:01

answered Feb 18 '20 at 07:53

Josh Wulf

4,727
2
20
34

score 11 · Answer 4 · answered Jan 28 '21 at 18:01

11

Workaround to use it with older Typescript version

await (Promise as any).allSettled(promises);

answered Jan 28 '21 at 18:01

Devil Sparrow

151
1
2

1

The most straightforward, one-liner answer! – Radityo Ardi Feb 16 '21 at 20:21
5

Dont do this if you dont have to. – Lukáš Gibo Vaic Mar 02 '21 at 08:20
1

This is a hack to get the TS compiler to pass. Instead, you should use a shim library such as https://www.npmjs.com/package/@types/promise.allsettled to avoid modifying production code – Woodz Apr 28 '21 at 02:36
still is an issue in 2023 and this was simple straightforward fix. rocker !!! – jnsnsml Jun 16 '23 at 07:53

score 5 · Answer 5 · edited Dec 07 '21 at 01:34

5

What worked for me was to simply add "es2020" into the "lib" attribute of tsconfig.json file

edited Dec 07 '21 at 01:34

Henry Ecker

34,399
18
41
57

answered Nov 08 '21 at 17:22

Ramón Espinosa

151
2
4

score 2 · Answer 6 · answered Apr 28 '21 at 02:35

There is a shim library available that provides identical functionality (https://www.npmjs.com/package/promise.allsettled), but note that it requires an explicit import (var allSettled = require('promise.allsettled');).

If you are working in typescript, the equivalent typed package is https://www.npmjs.com/package/@types/promise.allsettled, but note that the type names do not match the official ES2020 implementation, so if you want an exact drop-in replacement, you will need to add a new TS file to alias the types and make available in the global namespace:

import { PromiseRejection, PromiseResolution, PromiseResult } from 'promise.allsettled';

// https://stackoverflow.com/a/59499895/323177
export {}

// TechDebt: Remove once project is migrated to ES2020
// Global type aliases are required because the promise.allsettled shim doesn't match the types of the actual 
// ES2020 implementation
declare global {
    export type PromiseFulfilledResult<T> = PromiseResolution<T>;
    
    export type PromiseRejectedResult = PromiseRejection<any>;
    
    export type PromiseSettledResult<T> = PromiseResult<T, any>;

    export class PromiseConstructor {
        /**
         * Creates a Promise that is resolved with an array of results when all
         * of the provided Promises resolve or reject.
         * @param values An array of Promises.
         * @returns A new Promise.
         */
         allSettled<T extends readonly unknown[] | readonly [unknown]>(values: T):
             Promise<{ -readonly [P in keyof T]: PromiseSettledResult<T[P] extends PromiseLike<infer U> ? U : T[P]> }>;

        /**
         * Creates a Promise that is resolved with an array of results when all
         * of the provided Promises resolve or reject.
         * @param values An array of Promises.
         * @returns A new Promise.
         */
        allSettled<T>(values: Iterable<T>): Promise<PromiseSettledResult<T extends PromiseLike<infer U> ? U : T>[]>;
    }
}

score 0 · Answer 7 · answered May 18 '22 at 12:09

0

@types/node needs to be updated

A working version is here:

npm i @types/node@17.0.33

You can see versions from here

answered May 18 '22 at 12:09

Murat Colyaran

2,075
2
8
27

Property 'allSettled' does not exist on type 'PromiseConstructor'.ts(2339)

7 Answers7

Linked