@Recover (fallback method) is not getting invoked when used with @CircuitBreaker, once all the retry gets exhaused

Question

Though with other return type Spring retry fallback mechanism seems to be working fine, but when it comes to calling an API with return type void. Recover method is not getting called at all, I have tried with all possible type of method parameters and changing the return type of the fallback method.... Is thr any way to do it? I don't understand why the @CircuitBReaker annotation doesn't have a parameter to take the fallback method name passed as a value to it?

    @CircuitBreaker(maxAttempts = 3, openTimeout = 8000, resetTimeout = 15000)
    public Void callingXYZ(final Abc abc, final Cdf cdf) {
        return retryTemplate.execute(context -> {
            log.info("Retry count={} when calling ******", context.getRetryCount());
            AbcServiceImpl.this.update*****Settings(OrgId.fromString(abc.getUUID(), cdf.getData());
            return null;
        });
    }

   //Recover method that should get invoked
    @Recover
    public Void fallbackUpdate*****(Throwable e, Abc abc) throws Throwable{
        log.info("Inside fallback");
        if (e instanceof ClientException) {
            log.warn("Fallback method is called when trying to call ******** from ****** because of {}", e.getCause());

   //Rollback in the db based on the method attributes
            throw SpecificException.forTask(HttpStatus.SERVICE_UNAVAILABLE.value(),
                    Enum.NAME.getErrorCode(),
                    Enum.NAME.getMEssage(), true);
        }
        throw e;
    }

https://github.com/spring-projects/spring-retry/issues/194 – Arnav Karforma Feb 17 '20 at 10:57 — Arnav Karforma, Feb 17 '20 at 10:57

score 1 · Answer 1 · answered Feb 24 '21 at 09:36

Have you ever annotated a method with @Transactional (or e.g. @Async) and it didn’t work? As if it was totally ignored by Spring? This is because annotations like these can’t be (at least by default) put just on any method, the following two conditions must be met to let Spring take an action:

The method visibility can’t be any other than public. The invocation must come from outside of the bean. This is due to how Spring proxying work by default (using CGLIB proxies). I won’t dive into details, because it’s a topic wide enough to write another article, but generally speaking, when you autowire a bean of type Sample, Spring in fact doesn’t provide you exactly with an instance of Sample. Instead it injects a generated proxy class which extends Sample (that’s the reason why you can’t make your spring bean classes final) and overrides its public methods to be able to add extra behaviour (like transactional support).

That’s why methods with @Transactional must be public (so Spring can easily override them) and also that’s why the invocation must come from outside (only then it may go through a proxy, Spring can’t replace this reference with a proxy reference).

Taken from https://codete.com/blog/5-common-spring-transactional-pitfalls/

prathamesh patil · Answer 2 · 2020-02-17T16:56:18.980

0

Try using @Retryable it works for me

 <dependency>
        <groupId>org.springframework.retry</groupId>
        <artifactId>spring-retry</artifactId>
        <version>1.1.5.RELEASE</version>
    </dependency>

@Retryable(value = { NullPointerException.class},maxAttempts = 2)
public void retry() throws NullPointerException{
    throw new NullPointerException("something went wrong");
}

@Recover
public void recover(NullPointerException ex)
{
    System.out.println("iniside recover");
}

For more details check this link https://www.baeldung.com/spring-retry

edited Feb 17 '20 at 16:56

answered Feb 17 '20 at 16:43

prathamesh patil

21
3

But it won't let me use the CircuitBreaker pattern...I want to have the gap in between last retry and reset to let the corresponding service called to recover. – Arnav Karforma Feb 17 '20 at 17:31
I want to use retry and circuitbreaker both at the same time – Arnav Karforma Feb 17 '20 at 17:44

score 0 · Accepted Answer · answered Feb 20 '20 at 12:08

0

I resolved the issue in my code, it had nothing to do with spring-retry project. I was unable to find the solution of my issue because of my lack of understanding in Spring implementation of AOP. As Spring's aspect is applied to a proxy surrounding the bean not the actual class, calling a method with @circuitbreaker won't work if it is called from a same class/Service.

answered Feb 20 '20 at 12:08

Arnav Karforma

112
2
12

If anyone faces the same issue and yet struggles with the solution do comment here I will try to explain with a code example. In sort if you are using inbuilt Spring's AOP you can get this working if you don't move all the circuitBreaker methods to a new or different service. – Arnav Karforma Feb 20 '20 at 12:10

@Recover (fallback method) is not getting invoked when used with @CircuitBreaker, once all the retry gets exhaused

3 Answers3