error because of missing object in signalslot (tx_news)

Question

i wrote a signalslot extension for tx_news which extends the detailAction. The dispatcher works as expected when a news in detail view is called. But when the detail page is called without valid parameters for a existing news entry i get the following error:

Oops, an error occurred!
Argument 1 passed to .....\Slots\NewsControllerSlot::detailActionSlot() must be an instance of GeorgRinger\News\Domain\Model\News, null given

The error is easy to understand:

public function detailActionSlot(News $newsItem, $currentPage, $demand, $settings, $extendedVariables)

the first parameter $newsItem is missing.

But how can i avoid the error? Thanks!

score 1 · Answer 1 · answered Feb 11 '20 at 06:51

1

Create a pr on github or at least an issue, this is a bug

answered Feb 11 '20 at 06:51

Georg Ringer

7,779
1
16
34

Thank you Georg, i made an issue at github. But it seems that it is simply an error of me ... – lisardo Feb 11 '20 at 21:47

score 0 · Accepted Answer · answered Feb 11 '20 at 21:45

0

David Bruchmann gave me a hint:

public function detailActionSlot(News $newsItem = null, $currentPage, $demand, $settings, $extendedVariables)
{
    if (is_object($newsItem)) { 
        // do stuff here
   }
}

works perfectly even the 404 is thrown.

answered Feb 11 '20 at 21:45

lisardo

1,322
16
31

error because of missing object in signalslot (tx_news)

2 Answers2