I am not able to check if there is data in variable in laravel 6 with count() collection

Question

I am not able to check if there is data in the variable in laravel 6. Here is the function. Here the problem is $tags->count() is not hitting else statement

public function index(){

    $tags = Constant_model::getDataAllWithLimit('tags',"id",'DESC',50);

    if ($tags->count() >0) {

        $data = array(
            'title'=>'All Tags',
            'description'=>'All Tags',
            'seo_keywords'=>'All Tags',
            'tags'=>$tags
        );

        return view('tags',$data); 

    }else{
        $data = array(
            'title'=>"Page Not found",
            'description'=>"Page not found",
            'seo_keywords'=>'',
            );

            return view('404',$data);
    }
}

Here is getDataAllWithLimit function

public static function getDataAllWithLimit($table,$order_column,$order_type,$limit){
    $data = DB::table("$table")->orderBy("$order_column", "$order_type")
      ->paginate($limit);
      return $data;
  }

`DB::table("$table")` - That will still work, PHP extrapolates variables inside of double quotes, but it's not necessary, `DB::table($table)` is cleaner. — Tim Lewis, Jan 23 '20 at 15:52
1) $data = DB::table("$table")->orderBy("$order_column", "$order_type") should be $data = DB::table($table)->orderBy($order_column, $order_type) — Praveen Govind, Jan 23 '20 at 15:53
I am able to fetch data! not able to perform if else statement — Upasana Chauhan, Jan 23 '20 at 15:54
`dd($tags)` to see the results? Can you even `count()` a paginated result? Won't that always be > 0, since it has `total`, `per_page`, `last_page` etc? — brombeer, Jan 23 '20 at 15:55
getting this with dd($tags) - Illuminate\Pagination\LengthAwarePaginator {#332 ▼ #total: 128 #lastPage: 3 #items: Illuminate\Support\Collection {#275 ▶} #perPage: 50 #currentPage: 1 #path: "http://127.0.0.1:8000/tags" #query: [] #fragment: null #pageName: "page" +onEachSide: 3 #options: array:2 [▶] } — Upasana Chauhan, Jan 23 '20 at 15:58
It seems currentPage is 1, and perPage: 50, so the count is 50, greater than 0, so it will not hit the else statement. — TsaiKoga, Jan 23 '20 at 16:02
Yeah, sorry, I was totally wrong, you can in fact `->count()` pagination results. This will get the number of items for the current page. If you want to count all items it's `if ($tags->total() >0) {` — brombeer, Jan 23 '20 at 16:07
are you sure your collection has no return to went trough in else statement ? — Qonvex620, Jan 23 '20 at 16:49

Tohid Dadashnezhad · Answer 1 · 2020-01-23T16:35:37.747

Try this and hope it helps...

    if (count($tags->toArray()['data']) > 0) {

    $data = array(
        'title'=>'All Tags',
        'description'=>'All Tags',
        'seo_keywords'=>'All Tags',
        'tags'=>$tags
    );

    return view('tags',$data); 

}else{
    $data = array(
        'title'=>"Page Not found",
        'description'=>"Page not found",
        'seo_keywords'=>'',
        );

        return view('404',$data);
}

Karl Hill · Answer 2 · 2020-01-23T16:46:59.367

You can just use PHP's count() to count all the elements.

public function index()
{
    $tags = Constant_model::getDataAllWithLimit('tags', 'id', 'DESC', 50);

    if (count($tags) > 0) {

        $data = array(
            'title' => 'All Tags',
            'description' => 'All Tags',
            'seo_keywords' => 'All Tags',
            'tags' => $tags
        );

        return view('tags', $data);
    }

    $data = array(
        'title' => 'Page Not found',
        'description' => 'Page not found',
        'seo_keywords' => '',
    );

    return view('404', $data);
}

public function getDataAllWithLimit($table, $order_column, $order_type, $limit)
{
    return DB::table($table)->orderBy($order_column, $order_type)->paginate($limit);
}

I am not able to check if there is data in variable in laravel 6 with count() collection

2 Answers2