RecyclerView adapter `onCreateViewHolder` & `onBindViewHolder` invoked only once

Question

I have a RecyclerView.Adapter like this:

internal class MyAdapter : RecyclerView.Adapter<MyAdapter.MyViewHolder>() {
  private val data: List<MyModel> = SeedData().seed()

  override fun onCreateViewHolder(v: ViewGroup, viewType: Int): MyViewHolder {
    val binding = MyListitemBinding.inflate(LayoutInflater.from(v.context), v, false)
    return MyViewHolder(binding)
  }

  override fun getItemCount() = data.size

  override fun onBindViewHolder(holder: MyViewHolder, position: Int) {
    holder.bind(data[position])
  }
}

However, only the first item from the data is getting displayed (i.e. onCreateViewHolder & onBindViewHolder invoked only one time). How can I make it display all items from the data properly?

So the `data.size` is not returning `1`, it's returning some number which is more that one - is that right? — Reaz Murshed, Nov 13 '19 at 17:58
There is a chance that your RecyclerView height is too small. — EpicPandaForce, Nov 13 '19 at 18:01
@EpicPandaForce That would explain why `onBindViewHolder` gets called only once? — IgorGanapolsky, Nov 13 '19 at 18:02
Yes, @moumenShobakey is right. If you try to scroll then you can see that it invoke `onBindViewHolder` again — Md. Asaduzzaman, Nov 13 '19 at 18:26

score 0 · Accepted Answer · answered Nov 13 '19 at 18:29

0

The commented answers above are correct. My list item (views) were full height of screen:

This means that RecyclerView would only update the ViewHolder once you scroll to the next element. The solution is to modify the height of these items.

answered Nov 13 '19 at 18:29

IgorGanapolsky

26,189
23
116
147

RecyclerView adapter `onCreateViewHolder` & `onBindViewHolder` invoked only once

1 Answers1