How to solve: UnboundLocalError: local variable 't' referenced before assignment? in python?

Question

I am trying to implement the Simulated Annealing (SA) algorithm to solve a random instance of the Traveling Salesman Problem (TSP) in python. In my code, I have a function that computes the total longitude of the tour, given a list with the route and the distance matrix. When I run my code I have the following error related to this function.

UnboundLocalError: local variable 't' referenced before assignment

My code es the following:

N=4
D=np.zeros([N,N])
random.seed(13)

for i in range(N):
    for j in range(N):
        D[i,j]=random.randint(15,100)

for i in range(N):
    D[i,i]=10000

print("")
print("- Number of cities=",N)
print("")
print("- =")
print("- Distance matrix")
print(D)
#GENERATE ROUTES FUNCTION:
def generar_tour(N):
    ruta=range(N)
    ruta_obtenida=random.sample(ruta,len(ruta))
    return ruta_obtenida

#Function for calculating the length of the route

def distancia_tour(ejemplo,D):
    longitud=0
    for t in range(len(ejemplo)-1):
        longitud=longitud+D[ejemplo[t],ejemplo[t+1]]
    longitud=longitud+D[ejemplo[t+1],ejemplo[0]]
    return longitud

#SIMULATED ANNEALING ALGORITHM
T_inicial=5000
tour_inicial=generar_tour(N)
distancia_inicial=distancia_tour(tour_inicial,D)
print("TOUR INICIAL=",tour_inicial,"| LONGITUD TOUR=",distancia_tour(tour_inicial,D))
tour_actual=[]
tour_vecino=[]
distancia_vecino=0
distancias=[]
iteracion=[]
IT_max=1000
iterador=1
contar=1

while T_inicial>10**(-5):
    while iterador>IT_max:
        tour_vecino=generar_tour(N)
        distancia_vecino=distancia_tour(tour_vecino,D)
        if distancia_vecino-distancia_inicial<0:
            tour_actual=tour_vecino
        else:
            if random.random()<math.exp(-(distancia_vecino-distancia_inicial)/T_inicial):
                tour_actual=tour_vecino
        iterador=iterador+1
    T_inicial=0.9999*T_inicial
    print("RUTA=",tour_actual,"|","DISTANCIA TOTAL=",distancia_tour(tour_actual,D),"|","TEMPERATURA ACTUAL=",T_inicial)
    distancias.append(distancia_tour(tour_actual,D))
    iteracion.append(contar)
    contar=contar+1

plt.plot(contar,distancias,'b')
plt.show()

I had to search it on google, but using the most common solution as "global" and others don't work. Any ideas? I am sure that is not a hard problem, just I don't see it. Any hints? Thanks in advance and greetings from Chile.

score 0 · Answer 1 · answered Nov 08 '19 at 03:55

It means that you tried to read from t when the computer has never seen t before. Suppose you wrote something like:

x = t*99 + 3

.... but t never appeared answered earlier in the program. The computer can't multiply t by 99 unless it knows what t is. You tried to do something using t before ever assigning anything to it.

Craig · Accepted Answer · 2019-11-08T14:23:36.303

As, Samuel Muldoon says in his answer, the error means that you tried to use t before you set its value. The challenge in your code is that it's difficult to see how that could happen. It looks like you always set t in the for loop in distancia_tour, so how could it not be set?

It turns out that, owing to an error in your code, you pass an empty list to your distancia_tour function. The length of the empty list is 0 so your for loop is effectively:

for t in range(-1):
    ...

range(-1) returns an empty list, so there are no values to iterate over in the for loop. t is never given a value and you get the error when t is referenced on the next line after the for loop.

The reason it gets an empty list is that you initialize tour_actual to an empty list and then don't change it's value because of an error in your while statement. You have while iterador>IT_max:, which never executes because iterador is less than IT_max. You probably meant to test for iterador < IT_max.

score 0 · Answer 3 · answered Nov 10 '22 at 15:09

Here is my suggestion (and it works (: !): When using a if-clause in a function and a variable to iterate upon --> either all the block of script will fall under the if-clause including the initialization var = 0 and its final value (case 1 below) --> or the initialization and the final value will be outside the if-clause (case 2 below) --> but in no case will one of them be in the if-clause unless an error appears, namely this one : "UnboundLocalError: local variable 'variable' referenced before assignment)"

case 1:

def dist_hamming(A, B):
    if len(A) == len(B):        
        dist = 0         #My variable "dist" is inside the if-clause
        for i in range(len(A)):
            if A[i] != B[i]:
                dist += 1
        distance = dist   #Again my variable is inside the if-clause
        return distance 
    else:
        print("Please ensure the lenghts of the two sequence entered are identical !")

case 2:

def dist_hamming(A, B):
    dist = 0        #My variable "dist" is outside the if-clause
    if len(A) == len(B):        
        for i in range(len(A)):
            if A[i] != B[i]:
                dist += 1
    else:
        print("Please ensure the lenghts of the two sequence entered are identical !")
    distance = dist  #Again, my variable is outside the if-clause
    return distance

How to solve: UnboundLocalError: local variable 't' referenced before assignment? in python?

3 Answers3