java method refactoring when multiple if statements are used

Question

How to refactor the below code when multiple if statements are used? Is there an alternate way for doing this?

    StringBuffer sb = new StringBuffer();

    if (rowData.size() > 24){
        sb.append(rowData.get(24).trim());
    }
    sb.append("|");

    if (rowData.size() > 25){
        sb.append(rowData.get(25).trim());
    }
    sb.append("|");

    if (rowData.size() > 26){
        sb.append(rowData.get(26).trim());
    }
    sb.append("|");

    if (rowData.size() > 27){
        sb.append(rowData.get(27).trim());
    }
    sb.append("|");

    if (rowData.size() > 28){
        sb.append(rowData.get(28).trim());
    }
    sb.append("|");

    if (rowData.size() > 29) {
        sb.append(rowData.get(29).trim());
    }

It looks like you could just use a for loop to loop over the number in the condition. Have you tried that? — Carcigenicate, Nov 05 '19 at 19:00

Curiosa Globunznik · Accepted Answer · 2019-11-05T19:16:30.573

3

Putting the indexing in a loop as suggested would give you this

    for (int i = 24; i < 30; i++) {   
        if (rowData.size() > i){         
            sb.append(rowData.get(i).trim());
            sb.append(i <= 29 ? "|" : "");
        }
    }

In a more contemporary Java version also this could be done:

    IntStream.range(24, 29).forEach(i ->
    {            
        if (rowData.size() > i){         
            sb.append(rowData.get(i).trim());
            sb.append(i <= 29 ? "|" : "");
        }
    });

edited Nov 05 '19 at 19:16

answered Nov 05 '19 at 19:07

Curiosa Globunznik

3,129
1
16
24

That will have an extra | in the beginning. Also, the upper limit of range is exclusive, so either use rangeClosed or 30. – radulfr Nov 05 '19 at 19:13
maybe the separator is not dependent on size (always the same quantity....) – user85421 Nov 05 '19 at 19:19

java method refactoring when multiple if statements are used

1 Answers1