Authentication with nodejs

Question

I have a problem to make login work in my nodejs app. When I authenticate even if I enter the wrong user I have my page home render:

This is my code for the authentication:

app.post('/auth', urlencodedParser, function(req, res) {
    var username = "'" + req.body.usernames + "'";
    var password = "'" + req.body.passwords + "'";
    var client = new Client(conString);
    client.connect();
    if (username && password) {
        client.query('SELECT * FROM Utilisateur WHERE username = ? AND password = ?', [username, password],function(err, results) {
            if (err) {
               console.log('error running the authentication:', err);
            }
            results = JSON.parse("[{},{}]")
            if (results.length > 0) {
                req.session.loggedin = true
                req.session.username = username
                res.render('home')
            }
        });
    }
});

`results = JSON.parse("[{},{}]")` - This is the problem. You are ignoring the query results and assigning an array with two empty items to results and results.length passes. — Mat J, Nov 02 '19 at 17:53
Yes indeed I solve the problem by doing **if (results["rowCount"] > 0)** and by removing **results = JSON.parse("[{},{}]")** — Tarek Tarek, Nov 02 '19 at 18:24

score 0 · Accepted Answer · answered Nov 02 '19 at 17:51

Use sql library instead of client.

app.post('/auth', urlencodedParser, function(req, res) {
        var username = "'" + req.body.usernames + "'";
        var password = "'" + req.body.passwords + "'";
        var mysql = require('mysql');
        var con = mysql.createConnection({
          host: "localhost",
          user: "yourusername",
          password: "yourpassword",
          database: "mydb"
       });

        if (username && password) {
            con.connect(function(err) {
                 if (err) throw err;
                 con.query('SELECT * FROM Utilisateur WHERE username = ? AND password = ?', [username, password],function(err, results) {
                    if (err) {
                        console.log('error running the authentication:', err);
                    }
                    results = JSON.parse("[{},{}]")
                    if (results.length > 0) {
                        req.session.loggedin = true
                        req.session.username = username
                        res.render('home')
                    }
                 });  
            });
        }
    });

Authentication with nodejs

1 Answers1