Retrieve display profiles using UID on a FirestoreRecycler Adapter using Kotlin?

Question

I am having difficulties retrieving the information correctly from Firebase Firestore for my Recycler Adapter. I am not sure what I might be doing wrong but I used a Document Reference to get the required field but now it seems to just copy the same thing over and over, I want it to display each created users profile and display it on my RecyclerAdapter but am not sure what I should do and have tried different methods but get a

"No setter/field error" on my Model Class "Users".

This is my Firebase Schema This is what it is outputting

This is what I have my code as so far

[Update] This is what I have imported

import Models.User
import android.content.Intent
import android.content.res.Configuration
import androidx.appcompat.app.AppCompatActivity
import android.os.Bundle
import android.util.Log
import android.view.LayoutInflater
import android.view.MenuItem
import android.view.View
import android.view.ViewGroup
import android.widget.TextView
import android.widget.Toast
import androidx.appcompat.app.ActionBarDrawerToggle
import androidx.appcompat.widget.Toolbar
import androidx.core.view.GravityCompat
import androidx.drawerlayout.widget.DrawerLayout
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
import com.firebase.ui.firestore.FirestoreRecyclerAdapter
import com.firebase.ui.firestore.FirestoreRecyclerOptions
import com.google.android.material.navigation.NavigationView
import com.google.firebase.auth.FirebaseAuth
import com.google.firebase.firestore.*
import com.squareup.picasso.Picasso
import de.hdodenhof.circleimageview.CircleImageView
import kotlinx.android.synthetic.main.all_nearby_users.*
import kotlinx.android.synthetic.main.toolbar_layout.*

Oncreate

       auth = FirebaseAuth.getInstance()
        val customUserId = auth.currentUser!!.uid
        val db = FirebaseFirestore.getInstance()
        val userRef = db.collection("sUsers").document(customUserId)
        val userQuery = db.collection("sUsers").orderBy("Full Name", Query.Direction.DESCENDING).limit(10)

//User List Layout
        all_users_nearby_list.layoutManager = LinearLayoutManager(this)

        //Firestore
        val firestoreRecyclerOptions: FirestoreRecyclerOptions<Users> = FirestoreRecyclerOptions.Builder<Users>()
            .setQuery(userQuery, Users::class.java)
            .build()
        adapter = UserFirestoreRecyclerAdapter(firestoreRecyclerOptions)
        all_users_nearby_list.adapter = adapter

Firestore Recycler Adapter

private inner class UserFirestoreRecyclerAdapter internal constructor
        (firestoreRecyclerOptions: FirestoreRecyclerOptions<Users>): FirestoreRecyclerAdapter<Users, UserViewHolder>(firestoreRecyclerOptions) {

            override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): UserViewHolder {
                val userView = LayoutInflater.from(parent.context)
                    .inflate(R.layout.display_users_profile, parent, false)

                return UserViewHolder(userView)
            }

            override fun onBindViewHolder(holder: UserViewHolder, position: Int, model: Users) {

                holder.setFullname(model.fullname)
                holder.setProfileimage(model.profileImage)

            }

        }

UserViewHolder

   private inner class UserViewHolder internal constructor (private val pView: View) : RecyclerView.ViewHolder(pView) {


        internal fun setFullname(fullname: String) {
            val username = pView.findViewById<TextView>(R.id.usernameTextView)
            val db = FirebaseFirestore.getInstance()
            val docRef = db.collection("sUsers").document(auth.currentUser!!.uid)
            docRef.get()
                .addOnSuccessListener { document ->
                    if (document != null) {
                        Log.d("HomeActivity", "DocumentSnapshot data: ${document.data}")
                        username.text = document.getString("Full Name")

                    } else {
                        Log.d("HomeActivity", "No such document")
                    }
                }
                .addOnFailureListener { exception ->
                    Log.d("HomeActivity", "get failed with ", exception)
                }


            username.text = fullname
            Log.d("HomeActivity", "Current Data: " + fullname)
        }

        internal fun setProfileimage(profileImage: String) {
            val userProfileImage = pView.findViewById<CircleImageView>(R.id.profileUserImage)
            Picasso.get().load(profileImage).into(userProfileImage)
        }

    }

Model Class

package Models

    class Users(
    var fullname: String= "",
    var profileImage: String= "",
    var uid: String? = "",
    var haircut: Boolean? = null,
    var waxing: Boolean? = null,
    var nails: Boolean? = null,
    var profileRatingBar: Float? = 1.0f
)

My onStart and onStop

   override fun onStart() {
        super.onStart()
        adapter!!.startListening()
    }

    override fun onStop() {
        super.onStop()

        if (adapter != null) {
            adapter!!.stopListening()
        }
    }

Answer 1

This is how I would write your RecyclerView. Key points:

• Don't make a 2nd FireStore query inside the ViewHolder
• Your Firestore schema must exactly match your model
• Use lifecycle owner instead of onStart/onStop
• Firebase UI doesn't capture the uid; so do this manually (see apply)
• ViewHolder must "hold" the views as fields (to avoid calling find every time)
• Model represents 1 object, so I name it "User" not "Users"
• Set layoutManager in XML to reduce boilerplate in onCreate

Layout XML

<androidx.recyclerview.widget.RecyclerView
    ...
    app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
    tools:itemCount="5"
    tools:listitem="@layout/display_users_profile"
    ... />

Activity onCreate

val query = FirebaseFirestore.getInstance()
    .collection("sUsers") // Why not "users" ?
    .orderBy("fullname", Query.Direction.DESCENDING)
    .limit(10)

val options = FirestoreRecyclerOptions.Builder<User>()
    .setLifeCycleOwner(this)
    .setQuery(query) { it.toObject(User::class.java)!!.apply { uid = it.id } }
    .build()

all_users_nearby_list.adapter = UserFirestoreRecyclerAdapter(options)

Adapter

internal class UserFirestoreRecyclerAdapter(options: FirestoreRecyclerOptions<User>) : 
    FirestoreRecyclerAdapter<User, UserViewHolder>(options) {

    override fun onCreateViewHolder(parent: ViewGroup, viewType: Int) = 
        LayoutInflater.from(parent.context)
            .inflate(R.layout.display_users_profile, parent, false)
            .let { UserViewHolder(it) }

    override fun onBindViewHolder(holder: UserViewHolder, position: Int, model: Users) = 
        holder.bind(model)

}

ViewHolder

internal class UserViewHolder(itemView: View) : 
    RecyclerView.ViewHolder(itemView) {

    // Hold view refs
    private val usernameTextView: TextView = itemView.userNameTextView
    private val profileUserImage: ImageView = itemView.profileUserImage

    internal fun bind(model: User) {
        model.apply {
            usernameTextView.text = fullname
            Picasso.get().load(profileImage).into(profileUserImage)
        }
    }
}

Model

// Set sensible defaults here (or null if no sensible default)
data class User(
    var uid: String = "",
    var fullname: String= "",
    var profileImage: String= "",
    var haircut: Boolean = false,
    var waxing: Boolean = false,
    var nails: Boolean = false,
    var profileRatingBar: Float? = null
)