6

I have an odd case where adding a record is causing unwanted loading of a related collection.

For example, I have Requests and Sessions. A Session can contain many Requests. I already have loaded the session, and just want to add a new request.

However, when I set call AddObject on the ObjectSet of the Request repository, SQL Profiler shows a select query getting executed on all related requests on that session.

Here is the problem code:

this._request = new Request
                    {
                        Action = (string)filterContext.RouteData.Values["action"],
                        Controller = filterContext.Controller.GetType().Name,
                        DateAdded = userContext.Session.DateLastActive,
                        IpAddress = filterContext.HttpContext.Request.UserHostAddress,
                        SessionId = userContext.Session.Id
                    };

loggingService.AddRequest(this._request);

That last line just calls into my service, which in turn, just calls _objectSet.AddObject(entity).

The same thing would happen if I tried setting the new Request's Session = userContext.Session (instead of the above SessionId = userContext.Session.Id) -- the query would execute on setting this property, instead of on AddObject. So it's seems EF4 thinks it needs the related Request collection on the Session when it's referenced for some reason.

But I don't need the associated requests on the session, nor are the being used or referenced. So I'm not sure why EF4 is loading them. I stepped through the code, and verified that this happens exactly on the AddObject(entity) line (Profiler shows the query getting executed at the same instance).

Why would this happen, and how can I stop it?

Thanks in advance.

EDIT: Is this because EF4 is trying to add the new Request to the related Session.Requests collection, and goes and retrieves all of the other ones too? If so, is there any way to prevent that? Like I said, I don't need those Requests, I just need to add it and move on.

Jerad Rose
  • 15,235
  • 18
  • 82
  • 153

1 Answers1

6

I guess you are using POCO T4 template which suspects exactly this behavior. The problem are fixup methods generated by POCO template. Every time you assign navigation property, foreign key or add object to collection of related objects these methods performs object graph fixup. It means they update navigation on related entity as well. In your scenario it means that fixup methods adds Request to Requests collection in the Session. Access to the collection will trigger lazy loading. The only ways to avoid this are:

  • Turn off lazy loading for this operation (context.ContextOptions.LazyLoadingEnabled = false)
  • Remove Requests property from Session
  • Modify T4 template and remove fixup methods
  • Modify T4 template and remove virtual from Requests property (Session will not support lazy loading)
Ladislav Mrnka
  • 360,892
  • 59
  • 660
  • 670
  • Thanks, you are right, I'm using the POCO T4 template. It sounds like the first option may be the way to go (turn off lazy loading for this operation), as I don't want to permanently remove the Requests property or lazy loading abilities from this property. Now, I just need to figure this out with the repository pattern that I'm using. Thanks again. – Jerad Rose May 02 '11 at 13:37
  • For now, I am going with removing `virtual` from List properties, as these will cause the most issues when "rogue" lazy loading occurs. – Jerad Rose May 03 '11 at 13:40